Fix/SBOM graph scope path finding#1953
Merged
Merged
Conversation
Signed-off-by: rafi <refaei.shikho@hotmail.com>
…omponent parents Signed-off-by: rafi <refaei.shikho@hotmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts SBOM graph analysis and path-finding behavior to better respect artifact scoping when computing component-only dependency paths to a target PURL.
Changes:
- Updated
FindAllComponentOnlyPathsToPURLto terminate only at info-source nodes and to filter paths to the currently-scoped artifact. - Simplified
ComponentsWithMultipleSourcesby removing scope reset/restore logic and narrowing its doc comment to SBOM-only sources. - Added a regression test covering scope isolation when two artifacts share the same vulnerable dependency.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
normalize/sbom_graph.go |
Changes path-finding termination/scoping logic and adjusts multi-source component detection behavior. |
normalize/sbom_graph_test.go |
Adds a regression test ensuring scoped path-finding doesn’t return paths from other artifacts. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…lnerabilities Signed-off-by: rafi <refaei.shikho@hotmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.