edge proxy config API#3707
Open
cam-garrison wants to merge 2 commits into
Open
Conversation
Signed-off-by: Steve Kriss <skriss@redhat.com>
Signed-off-by: Cameron Garrison <cgarriso@redhat.com>
|
😊 Welcome @cam-garrison! This is either your first contribution to the Istio api repo, or it's been You can learn more about the Istio working groups, Code of Conduct, and contribution guidelines Thanks for contributing! Courtesy of your friendly welcome wagon. |
istio-testing
added
the
size/L
| } | ||
|
|
||
| // The config profile to use for this proxy. | ||
| ProxyConfigProfile profile = 43; |
Contributor
There was a problem hiding this comment.
How will this and below fields work together? When I select Edge profile, do I get some default values for the below configurations? I think it would be good to tie this profile and the below fields together or explain clearly how they work together?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Picks up and rebases #3627 (by @skriss) (addt'l adding release note).
Adds edge proxy configuration fields to
ProxyConfig— aprofileenum (SIDECAR/EDGE), connection buffer limits, HTTP timeouts, HTTP/2 tuning, header/path normalization, and connection limits. Enables native Istio support for Envoyedge proxy best practices.
Design per WG feedback: uses
profileenum instead of boolean. Overload manager out of scope for initial implementation.Related RFC: Edge Proxy Config
Supersedes #3627.
cc @skriss @keithmattix @dgn @frittentheke
ref. istio/istio#57973
ref. istio/istio#24715