Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
363 changes: 363 additions & 0 deletions kubernetes/customresourcedefinitions.gen.yaml

Large diffs are not rendered by default.

3 changes: 3 additions & 0 deletions networking/v1/destination_rule_alias.gen.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

173 changes: 123 additions & 50 deletions networking/v1alpha3/destination_rule.pb.go

Large diffs are not rendered by default.

46 changes: 45 additions & 1 deletion networking/v1alpha3/destination_rule.pb.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 14 additions & 0 deletions networking/v1alpha3/destination_rule.proto
Original file line number Diff line number Diff line change
Expand Up @@ -695,6 +695,20 @@ message ConnectionPoolSettings {
// The maximum number of concurrent streams allowed for a peer on one HTTP/2 connection.
// Defaults to 2^31-1.
int32 max_concurrent_streams = 8;

// Settings for HTTP/2 PING frames.
message ConnectionKeepalive {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you planning to default the jitter to envoy's default?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, should I make that configurable here?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. Just checking. Envoy default is fine.

// Send HTTP/2 PING frames at this interval. Required when
// `http2KeepAlive` is set.
google.protobuf.Duration interval = 1;

// How long to wait for a response to an HTTP/2 PING frame before
// closing the connection. Required when `http2KeepAlive` is set.
google.protobuf.Duration timeout = 2;
}

// Configure HTTP/2 PING frames for upstream connections.
ConnectionKeepalive http2_keep_alive = 9;
}

// Settings common to both HTTP and TCP upstream connections.
Expand Down
21 changes: 21 additions & 0 deletions networking/v1alpha3/destination_rule_deepcopy.gen.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 12 additions & 0 deletions networking/v1alpha3/destination_rule_json.gen.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions networking/v1beta1/destination_rule_alias.gen.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

15 changes: 14 additions & 1 deletion tests/testdata/destinationrule-valid.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -32,4 +32,17 @@ spec:
warmup:
duration: 300s
minimumPercent: 5.0
aggression: 5.0
aggression: 5.0
---
apiVersion: networking.istio.io/v1
kind: DestinationRule
metadata:
name: bookinfo-ratings-http2-ping
spec:
host: ratings.prod.svc.cluster.local
trafficPolicy:
connectionPool:
http:
http2KeepAlive:
interval: 15s
timeout: 5s