add windows and mac github runners

.claude/rules/code-coverage.md

@@ -0,0 +1,3 @@
+# Code Coverage Measurement
+
+- Use `make coverage` to measure code coverage. This is the authoritative source.

.github/actions/install-build-dependencies/action.yml

@@ -0,0 +1,20 @@
+name: install-build-dependencies
+description: Install OS-specific system packages needed to build llama-cpp-bindings (CMake, libclang, GNU make).
+
+runs:
+  using: composite
+  steps:
+    - name: install linux build dependencies
+      if: runner.os == 'Linux'
+      shell: bash
+      run: sudo apt-get update && sudo apt-get install -y cmake libclang-dev
+
+    - name: install windows build dependencies
+      if: runner.os == 'Windows'
+      shell: bash
+      run: choco install -y make
+
+    - name: set windows libclang path
+      if: runner.os == 'Windows'
+      shell: bash
+      run: echo "LIBCLANG_PATH=C:\\Program Files\\LLVM\\bin" >> $GITHUB_ENV

.github/actions/install-rust-toolchain/action.yml

@@ -0,0 +1,11 @@
+name: install-rust-toolchain
+description: Install the pinned stable Rust toolchain (with rustfmt and clippy) and configure the cargo build cache.
+
+runs:
+  using: composite
+  steps:
+    - uses: dtolnay/rust-toolchain@29eef336d9b2848a0b548edc03f92a220660cdb8 # stable
+      with:
+        components: rustfmt, clippy
+
+    - uses: Swatinem/rust-cache@v2

.github/workflows/unit-tests.yml

@@ -9,33 +9,40 @@ env:
   CARGO_TERM_COLOR: always
 
 jobs:
-  fmt:
+  formatting:
     name: formatting
     runs-on: ubuntu-latest
+    timeout-minutes: 30
     steps:
       - uses: actions/checkout@v4
         with:
           submodules: recursive
 
-      - uses: dtolnay/rust-toolchain@29eef336d9b2848a0b548edc03f92a220660cdb8 # stable
-
-      - uses: Swatinem/rust-cache@v2
+      - uses: ./.github/actions/install-rust-toolchain
 
       - run: make fmt.check
 
   test:
-    name: tests
-    runs-on: ubuntu-latest
+    name: tests (${{ matrix.os }})
+    runs-on: ${{ matrix.os }}
+    timeout-minutes: 30
+    strategy:
+      fail-fast: false
+      matrix:
+        os: [ubuntu-latest, windows-latest, macos-latest]
+    defaults:
+      run:
+        shell: bash
+    env:
+      LLAMA_DISABLE_CCACHE: '1'
+      RUST_BACKTRACE: '1'
     steps:
       - uses: actions/checkout@v4
         with:
           submodules: recursive
 
-      - name: install system dependencies
-        run: sudo apt-get update && sudo apt-get install -y cmake libclang-dev
-
-      - uses: dtolnay/rust-toolchain@29eef336d9b2848a0b548edc03f92a220660cdb8 # stable
+      - uses: ./.github/actions/install-build-dependencies
 
-      - uses: Swatinem/rust-cache@v2
+      - uses: ./.github/actions/install-rust-toolchain
 
       - run: make test.unit

.gitignore

@@ -14,3 +14,10 @@ target/
 
 # Mac stuff
 .DS_Store
+
+# Node modules (rust-coverage-check npm dependency)
+node_modules/
+
+# LLVM source-based coverage raw and merged profile artifacts
+*.profraw
+*.profdata

Makefile

@@ -2,11 +2,11 @@ TEST_DEVICE ?=
 QWEN_CAPABLE_FEATURES = multimodal_capable,mrope_model
 
 DEVICE_FEATURE = $(if $(TEST_DEVICE),--features $(TEST_DEVICE),)
-LLM_BASE_FEATURE_FLAGS = $(DEVICE_FEATURE)
 LLM_QWEN_CAPABLE_FEATURE_FLAGS = $(DEVICE_FEATURE) --features $(QWEN_CAPABLE_FEATURES)
 
-CARGO_TEST_LLM_FLAGS = --no-fail-fast -p llama-cpp-bindings-tests $(LLM_BASE_FEATURE_FLAGS) -- --test-threads=1
-CARGO_TEST_LLM_FLAGS_QWEN_CAPABLE = --no-fail-fast -p llama-cpp-bindings-tests $(LLM_QWEN_CAPABLE_FEATURE_FLAGS) -- --test-threads=1
+CARGO_TEST_LLM_FLAGS = --release --no-fail-fast -p llama-cpp-bindings-tests $(DEVICE_FEATURE) -- --test-threads=1
+CARGO_TEST_LLM_FLAGS_QWEN_CAPABLE = --release --no-fail-fast -p llama-cpp-bindings-tests $(LLM_QWEN_CAPABLE_FEATURE_FLAGS) -- --test-threads=1
+
 
 QWEN3_5_0_8B_ENV = \
 	LLAMA_TEST_HF_REPO=unsloth/Qwen3.5-0.8B-GGUF \
@@ -42,26 +42,56 @@ DEEPSEEK_R1_DISTILL_LLAMA_8B_ENV = \
 	LLAMA_TEST_HF_ENCODER_REPO=Xiaojian9992024/t5-small-GGUF \
 	LLAMA_TEST_HF_ENCODER_MODEL=t5-small.bf16.gguf
 
+node_modules: package-lock.json
+	npm ci
+	touch node_modules
+
+package-lock.json: package.json
+	npm install --package-lock-only
+
 .PHONY: clean.cmake
 clean.cmake:
 	rm -rf target/llama-cpp-cmake-build
 
 .PHONY: clippy
-clippy: clippy.core clippy.tests.base clippy.tests.qwen_capable
-
-.PHONY: clippy.core
-clippy.core:
+clippy:
+	cargo clippy --all-targets -p llama-cpp-bindings-types -- -D warnings
 	cargo clippy --all-targets -p llama-cpp-log-decoder -- -D warnings
+	cargo clippy --all-targets -p llama-cpp-bindings-build -- -D warnings
+	cargo clippy --all-targets -p llama-cpp-bindings-sys $(DEVICE_FEATURE) -- -D warnings
 	cargo clippy --all-targets -p llama-cpp-bindings $(DEVICE_FEATURE) -- -D warnings
-
-.PHONY: clippy.tests.base
-clippy.tests.base:
-	cargo clippy --all-targets -p llama-cpp-bindings-tests $(LLM_BASE_FEATURE_FLAGS) -- -D warnings
-
-.PHONY: clippy.tests.qwen_capable
-clippy.tests.qwen_capable:
+	cargo clippy --all-targets -p llama-cpp-bindings-tests $(DEVICE_FEATURE) -- -D warnings
 	cargo clippy --all-targets -p llama-cpp-bindings-tests $(LLM_QWEN_CAPABLE_FEATURE_FLAGS) -- -D warnings
 
+.PHONY: coverage
+coverage: node_modules
+	cargo llvm-cov clean --workspace
+	cargo llvm-cov --no-report -p llama-cpp-log-decoder
+	cargo llvm-cov --no-report -p llama-cpp-bindings-types
+	cargo llvm-cov --no-report -p llama-cpp-bindings --lib $(DEVICE_FEATURE)
+	$(DEEPSEEK_R1_DISTILL_LLAMA_8B_ENV) cargo llvm-cov --no-report --no-fail-fast -p llama-cpp-bindings-tests $(DEVICE_FEATURE) -- --test-threads=1
+	$(GLM4_7_FLASH_ENV) cargo llvm-cov --no-report --no-fail-fast -p llama-cpp-bindings-tests $(DEVICE_FEATURE) -- --test-threads=1
+	$(QWEN3_5_0_8B_ENV) cargo llvm-cov --no-report --no-fail-fast -p llama-cpp-bindings-tests $(LLM_QWEN_CAPABLE_FEATURE_FLAGS) -- --test-threads=1
+	$(QWEN3_6_35B_A3B_ENV) cargo llvm-cov --no-report --no-fail-fast -p llama-cpp-bindings-tests $(LLM_QWEN_CAPABLE_FEATURE_FLAGS) -- --test-threads=1
+	cargo llvm-cov report --json --output-path target/llvm-cov.json
+	cargo llvm-cov report --lcov --output-path target/lcov.info
+	cargo llvm-cov report
+	npx rust-coverage-check target/llvm-cov.json \
+		--workspace-root $(CURDIR) \
+		--gated llama-cpp-bindings=95 \
+		--gated llama-cpp-log-decoder=99 \
+		--gated llama-cpp-bindings-types=99
+
+.PHONY: coverage-clean
+coverage-clean:
+	cargo llvm-cov clean --workspace
+	rm -rf target/llvm-cov-target
+	rm -f target/llvm-cov.json target/lcov.info
+
+.PHONY: coverage-report
+coverage-report:
+	cargo llvm-cov report --html
+
 .PHONY: fmt
 fmt:
 	cargo fmt --all
@@ -74,11 +104,11 @@ fmt.check:
 test: test.unit test.llms
 
 .PHONY: test.deepseek_r1_distill_llama_8b
-test.deepseek_r1_distill_llama_8b: clippy.core clippy.tests.base
+test.deepseek_r1_distill_llama_8b: clippy
 	$(DEEPSEEK_R1_DISTILL_LLAMA_8B_ENV) cargo test $(CARGO_TEST_LLM_FLAGS)
 
 .PHONY: test.glm4_7_flash
-test.glm4_7_flash: clippy.core clippy.tests.base
+test.glm4_7_flash: clippy
 	$(GLM4_7_FLASH_ENV) cargo test $(CARGO_TEST_LLM_FLAGS)
 
 .PHONY: test.llms
@@ -89,14 +119,14 @@ test.llms: \
 	test.qwen3.6_35b_a3b
 
 .PHONY: test.qwen3.5_0.8B
-test.qwen3.5_0.8B: clippy.core clippy.tests.qwen_capable
+test.qwen3.5_0.8B: clippy
 	$(QWEN3_5_0_8B_ENV) cargo test $(CARGO_TEST_LLM_FLAGS_QWEN_CAPABLE)
 
 .PHONY: test.qwen3.6_35b_a3b
-test.qwen3.6_35b_a3b: clippy.core clippy.tests.qwen_capable
+test.qwen3.6_35b_a3b: clippy
 	$(QWEN3_6_35B_A3B_ENV) cargo test $(CARGO_TEST_LLM_FLAGS_QWEN_CAPABLE)
 
 .PHONY: test.unit
-test.unit: clippy.core
+test.unit: clippy
 	cargo test -p llama-cpp-log-decoder
 	cargo test -p llama-cpp-bindings $(DEVICE_FEATURE)

llama-cpp-bindings-build/src/cmake_config.rs

@@ -205,6 +205,7 @@ fn configure_platform_specific(
         TargetOs::Windows(WindowsVariant::Msvc) => {
             config.cflag("/w");
             config.cxxflag("/w");
+            config.cxxflag("/EHsc");
             configure_msvc_release_workaround(config, profile);
         }
         TargetOs::Android => {

llama-cpp-bindings-build/src/cpp_wrapper.rs

@@ -33,6 +33,7 @@ pub fn compile_cpp_wrappers(llama_src: &Path, target_os: &TargetOs) {
 
     if target_os.is_msvc() {
         build.flag("/std:c++17");
+        build.flag("/EHsc");
     }
 
     if target_os.is_android() && cfg!(feature = "static-stdcxx") {

llama-cpp-bindings-build/src/cpp_wrapper_mtmd.rs

@@ -23,6 +23,7 @@ pub fn compile_mtmd(llama_src: &Path, target_os: &TargetOs) {
 
     if target_os.is_msvc() {
         build.flag("/std:c++17");
+        build.flag("/EHsc");
     }
 
     if target_os.is_android() && cfg!(feature = "static-stdcxx") {