-
Notifications
You must be signed in to change notification settings - Fork 81
Fix REST API Ref links #3163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 5.0
Are you sure you want to change the base?
Fix REST API Ref links #3163
Changes from all commits
e5344f1
3ed6981
2082adc
1db7194
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -92,7 +92,7 @@ Those example `Accept-Path` headers above indicate that the content could be mod | |
|
|
||
| ### Location header | ||
|
|
||
| For example, [creating content](../rest_api_reference/rest_api_reference.html#managing-content-create-content-type) and [getting a content item's current version](/api/rest_api/rest_api_reference/rest_api_reference.html#tag/Objects/operation/api_contentobjects_contentIdcurrentversion_get) | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should also be fixed on 4.6, the text is "creating content" but it target "create content type" |
||
| For example, [creating content](/api/rest_api/rest_api_reference/rest_api_reference.html#tag/Objects/operation/api_contentobjects_post) and [getting a content item's current version](/api/rest_api/rest_api_reference/rest_api_reference.html#tag/Objects/operation/api_contentobjects_contentIdcurrentversion_get) | ||
| both send a `Location` header to provide you with the requested resource's ID. | ||
|
|
||
| Those particular headers generally match a specific list of HTTP response codes. | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -61,7 +61,7 @@ | |
|
|
||
| ## Rate limiting | ||
|
|
||
| To prevent malicious actors from trying all the possible discount code combinations using brute-force attacks, the [`/discounts_codes/{cartIdentifier}/apply` endpoint](/api/rest_api/rest_api_reference/rest_api_reference.html#discount-codes-apply-discount-to-cart) is rate limited using the [Rate Limiter Symfony component]([[= symfony_doc =]]/rate_limiter.html). | ||
| To prevent malicious actors from trying all the possible discount code combinations using brute-force attacks, the [`/discounts_codes/{cartIdentifier}/apply` endpoint](https://doc.ibexa.co/en/4.6/api/rest_api/rest_api_reference/rest_api_reference.html#discount-codes-apply-discount-to-cart) is rate limited using the [Rate Limiter Symfony component]([[= symfony_doc =]]/rate_limiter.html). | ||
|
Check notice on line 64 in docs/discounts/configure_discounts.md
|
||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Was documented only in RAML. See ibexa/discounts-codes#47 for an OpenAPI documentation. |
||
|
|
||
| You can adjust the default configuration by modifying the `config/packages/ibexa_discounts_codes.yaml` file created during installation process. | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typical custom method that wasn't documented at API Platform introduction time because not existing in OpenAPI 3.1.
But OpenAPI 3.2 supports it: https://learn.openapis.org/specification/http-methods.html#additional-operations-for-custom-methods
This is something to investigate on API Platform side.