deep-gemm: improve security#845
Open
sayakpaul wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had a security reporting:
"""
[LOW] .github/workflows/security-audit.yml:112-113 — Audit prompt drops explicit coverage of setup.py, pyproject.toml, and CMake ExternalProject_Add as fetch-at-build-time vectors
The removed text told the LLM auditor to specifically check "URLs in setup.py, pyproject.toml, CMake ExternalProject_Add" for unpinned network fetches. This is directly relevant: deep-gemm/setup.py:51,168-191 contains a CachedWheelsCommand that downloads pre-built wheels from https://github.com/DeepSeek-AI/DeepGEMM/releases/ at build time via urllib.request.urlopen with no SHA verification — only a version-based URL. An attacker who modifies the base_wheel_url or poisons the GitHub release would serve a malicious wheel to every builder. Removing setup.py from the explicit checklist makes it less likely the auditor will flag changes to this download path. The general principle ("Anything that pulls bytes from the network at build or import time without a SHA pin") still applies, but LLM auditors are measurably more reliable when given specific file types to check.
"""
This PR fixes that.