Fix getLabel() nullability for unlabeled events when label was deleted#2211
Open
Haarolean wants to merge 1 commit intohub4j:mainfrom
Open
Fix getLabel() nullability for unlabeled events when label was deleted#2211Haarolean wants to merge 1 commit intohub4j:mainfrom
getLabel() nullability for unlabeled events when label was deleted#2211Haarolean wants to merge 1 commit intohub4j:mainfrom
Conversation
a85ff6b to
0e9648f
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2211 +/- ##
=========================================
Coverage 85.14% 85.14%
Complexity 2525 2525
=========================================
Files 239 239
Lines 7461 7461
Branches 393 393
=========================================
Hits 6353 6353
Misses 872 872
Partials 236 236 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When a label is deleted from a GitHub repository, GitHub sends
unlabeledwebhook events for every issue/PR that had it. Unlike normalunlabeledevents, the payload omits the top-levellabelobject entirely, causinggetLabel()to returnnull.This was undocumented — the javadoc implied the label is always present for
labeled/unlabeledactions, likely leading consumers to NPE.Changes
@CheckForNullannotation togetLabel()inGHEventPayload.Discussion,GHEventPayload.Issue, andGHEventPayload.PullRequestnullis returnedlabelfieldGHEventPayload.Label.getLabel()is intentionally left unchanged — the label is the subject of that event type and should always be present.Before submitting a PR:
@linkJavaDoc entries to the relevant documentation on https://docs.github.com/en/rest .mvn -D enable-ci clean install site "-Dsurefire.argLine=--add-opens java.base/java.net=ALL-UNNAMED"locally. If this command doesn't succeed, your change will not pass CI.main. You will create your PR from that branch.When creating a PR: