Change How The Custom Font Is Loaded#310
Open
Bwc9876 wants to merge 4 commits intohuashengdun:masterfrom
Open
Conversation
Bwc9876
changed the title
|
bump |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Currently the custom font is loaded by assuming that it's the first item in
document.fonts, the problem with this is that some extension (namely Grammarly) will load their own custom fonts. On Firefox it seems like the fonts extensions load gets placed later in the list, but on Chrome the extension's font may be placed first. This results in the terminal font not being set properly and instead being set to the extension's font.Solution
Changes
main.jsto search for the font indocument.fontsby name instead of assuming it's the first. To get the name theindex.htmltemplate has been changed to place a custom data attribute for the font name in the<body>tag.