Update handler.py#144
Open
meramsey wants to merge 1 commit intohuashengdun:masterfrom
Open
Conversation
Add SSH Agent key support. Allows for SSH Agent use and key support if the local OS is setup for it thanks to Paramikos support of this. Courtesy of this excerpt https://github.com/paramiko/paramiko/blob/ae3d0febef17a8ece5268bbf6c210a30573ce800/demos/demo.py#L41-L59 and my mod adding "allow_agent=True, look_for_keys=True," to the string ssh.connect(*args, allow_agent=True, look_for_keys=True, timeout=options.timeout) This is working perfectly for me on Linux project and should work in Windows as well. http://docs.paramiko.org/en/stable/api/agent.html This will allow for easy switching of servers and key management for those embedding into custom apps.
Owner
|
Do you think it is really a good idea to enable these stuffs(allow_agent, look_for_keys) on your web server ? |
Author
|
This is being run from local host bound pyqt5 app as an embedded ssh terminal in my case and will be by the other people using it in the way I am.
That is great point of concern though. It would be a great option but probably should not be a default option that's enabled.
This could easily be added as a command line option to wssh.
It's brings great flexibility to building apps with custom Ssh terminals. Just felt like sharing it upstream as a courtesy as I felt like others might also like that option. I already have a highly customized version of webssh with the more "extreme" mods like Ssh config file and key handling from sqlite3 db which is cool but not probably something most would ever use.
Sent from Nine
…________________________________
From: Shengdun Hua <notifications@github.com>
Sent: Tuesday, April 7, 2020 02:36
To: huashengdun/webssh
Cc: WhatTheServer; Author
Subject: Re: [huashengdun/webssh] Update handler.py (#144)
Do you think it is really a good idea to enable these stuffs(allow_agent, look_for_keys) on your web server ?
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#144 (comment)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add SSH Agent key support.
Allows for SSH Agent use and key support if the local OS is setup for it thanks to Paramikos support of this.
Courtesy of this excerpt
https://github.com/paramiko/paramiko/blob/ae3d0febef17a8ece5268bbf6c210a30573ce800/demos/demo.py#L41-L59
and my mod adding "allow_agent=True, look_for_keys=True," to the string
ssh.connect(*args, allow_agent=True, look_for_keys=True, timeout=options.timeout)
This is working perfectly for me on Linux project and should work in Windows as well.
http://docs.paramiko.org/en/stable/api/agent.html
This will allow for easy switching of servers and key management for those embedding into custom apps.