Skip to content

Set JS compiler target to ES2015 in kotlin-multiplatform-js-browser-conventions#48

Merged
ShreckYe merged 1 commit intomainfrom
kotlin-js-es2015
Apr 18, 2026
Merged

Set JS compiler target to ES2015 in kotlin-multiplatform-js-browser-conventions#48
ShreckYe merged 1 commit intomainfrom
kotlin-js-es2015

Conversation

@ShreckYe
Copy link
Copy Markdown
Member

@ShreckYe ShreckYe commented Apr 17, 2026

Summary by CodeRabbit

  • Chores
    • Updated JavaScript compiler target to ES2015 in Kotlin Multiplatform JS configuration for enhanced compatibility.

@ShreckYe ShreckYe requested a review from Copilot April 17, 2026 22:15
@ShreckYe ShreckYe self-assigned this Apr 17, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 17, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: b3309f7c-e7bd-4402-8fc3-4e609b9a3274

📥 Commits

Reviewing files that changed from the base of the PR and between e3b37c3 and 39d4d2f.

📒 Files selected for processing (1)
  • kotlin-common-gradle-plugins/src/main/kotlin/com/huanshankeji/kotlin-multiplatform-js-browser-conventions.gradle.kts

📝 Walkthrough

Walkthrough

A Gradle Kotlin Multiplatform JS build configuration file is updated to add a compilerOptions block that sets the JavaScript compiler target to es2015, extending the existing js {} target setup without modifying control flow.

Changes

Cohort / File(s) Summary
Gradle Kotlin Multiplatform JS Compiler Configuration
kotlin-common-gradle-plugins/src/main/kotlin/com/huanshankeji/kotlin-multiplatform-js-browser-conventions.gradle.kts
Adds compilerOptions block within js {} target to set JavaScript compilation target to es2015.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A target so sleek, es2015 it shall be,
JavaScript flows like a gentle decree,
Compiler options nested just right,
Four lines of config, gracefully tight,
The browser builds bright, oh what a spree! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: setting the JS compiler target to ES2015 in the kotlin-multiplatform-js-browser-conventions Gradle configuration file.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch kotlin-js-es2015

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link
Copy Markdown

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Gradle convention script for Kotlin Multiplatform JS (browser) projects to compile JavaScript targeting ES2015, aligning the generated output with modern JS runtimes.

Changes:

  • Set Kotlin/JS compiler target to es2015 for the js { browser() } target in the kotlin-multiplatform-js-browser-conventions convention plugin.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Kotlin Multiplatform JS browser conventions by adding compiler options to set the target to "es2015". I have no feedback to provide as no review comments were submitted.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Kotlin Multiplatform JS browser conventions by configuring the compiler options to target ES2015. I have no feedback to provide as there are no review comments to evaluate.

@ShreckYe ShreckYe merged commit c4cfaf4 into main Apr 18, 2026
8 checks passed
@ShreckYe ShreckYe deleted the kotlin-js-es2015 branch April 18, 2026 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants