Conversation
Clarified descriptions for Lazy components and List.
…137) * Update README.md with missing modifiers, components, and other APIs - Modifiers: add rotate, clickable, wrapContentWidth/Height/Size, intrinsic size modifiers, scope modifiers; mark onClick and scroll modifiers as deprecated - Ext modifiers: add fillMaxWidthStretch/HeightStretch/SizeStretch, roundedCornerOuterBorder, hidden/reserveSpace/invisible, matchPositionRelativeParentJsDom - Foundation: add ext scroll layouts and containers - Material 3: add Scaffold, Badge (moved from ext), TopAppBar (moved from ext), Snackbar composable, scrollable tab rows; move Dialog to ext; add missing dropdown menu variants (DropdownMenuBox, outlined variants) - Other APIs: add Color, BorderStroke, IntrinsicSize, ScrollState, AnnotatedString/SpanStyle, text style types, font types Agent-Logs-Url: https://github.com/huanshankeji/compose-multiplatform-html-unified/sessions/e5bb5ef7-314b-4018-b0c0-7dfc28932027 Co-authored-by: ShreckYe <27768951+ShreckYe@users.noreply.github.com> * Address review: add Badge deprecation reason and specific scroll replacements Agent-Logs-Url: https://github.com/huanshankeji/compose-multiplatform-html-unified/sessions/e5bb5ef7-314b-4018-b0c0-7dfc28932027 Co-authored-by: ShreckYe <27768951+ShreckYe@users.noreply.github.com> * Update from review --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: ShreckYe <27768951+ShreckYe@users.noreply.github.com> Co-authored-by: Yongshun Ye <shreckye@gmail.com>
…tOverflow.Clip `overflow: hidden` on a blockified span in a flex container with `gap` (from Arrangement.spacedBy) causes the span height to collapse from 18px to ~4px, clipping the bottom half of text. Since `text-overflow: clip` is the CSS default and the `-webkit-line-clamp` block already applies `overflow: hidden` when maxLines is constrained, removing it from the Clip case fixes the bug without affecting truncation behavior. Agent-Logs-Url: https://github.com/huanshankeji/compose-multiplatform-html-unified/sessions/757d24fb-1bcc-45d8-83c5-73647f86a4a7 Co-authored-by: ShreckYe <27768951+ShreckYe@users.noreply.github.com>
…row-text-issue Fix text clipping in JS DOM: remove unnecessary `overflow: hidden` from default `TextOverflow.Clip`
Emphasize the demo site link in the README.
Updated link formatting for side-by-side demo site.
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new debugging guide for Kotlin file facade clashes and significantly updates the documentation to reflect new components, modifiers, and API changes. Key technical changes include adjustments to TextOverflow.Clip logic on JS and the addition of scroll container components. Feedback highlights a potential inconsistency in text clipping behavior where removing overflow: hidden might lead to unexpected visibility, a recommendation to finalize the package structure for new scroll components before release to avoid breaking changes, and a versioning mismatch in the changelog.
| // Don't apply `overflow: hidden` here. | ||
| // `text-overflow: clip` is the CSS default, and `overflow: hidden` on a blockified span | ||
| // (in a flex container with `gap`) causes the height to collapse, clipping the text. | ||
| // When `maxLines` is constrained, the `-webkit-line-clamp` block below already applies `overflow: hidden`. | ||
| } |
There was a problem hiding this comment.
The current implementation of TextOverflow.Clip does not apply any overflow clipping when maxLines is not constrained. In CSS, the text-overflow property only takes effect when overflow is set to a value other than visible. By removing overflow(Overflow.Hidden), the text will not be clipped at the container's bounds, making it behave identically to TextOverflow.Visible. This is inconsistent with the expected behavior in Compose UI where Clip should truncate the text at the container's edges. If overflow: hidden causes layout issues in flex containers, consider using overflow: clip (if supported by the CSS library) or documenting this limitation more explicitly.
| import com.huanshankeji.compose.foundation.layout.BoxScope | ||
| import com.huanshankeji.compose.ui.Modifier | ||
|
|
||
| // Also consider moving these to `com.huanshankeji.compose.foundation.layout.ext` because they depend on `Box` on Compose UI which is in the `layout` package. |
There was a problem hiding this comment.
Since this pull request is for a release (v0.6.1 per the title), it is recommended to resolve the package location for these components now. Moving them from foundation.ext to foundation.layout.ext later would be a breaking change for users. If they are conceptually layouts and depend on Box, they should ideally reside in the layout package to align with the structure of the standard Compose libraries.
| - Remove the `iosX64` targets. | ||
| - Support ES2015 compilation target for JS DOM by replacing `require()` with ES module imports. | ||
| - Use `Arrangement.spacedBy` from Kobweb (commit 53ff09f4d2aacfa7ec82c6afb6cfb352e8cc5e3a). | ||
| - Add reference links to component files and move existing ones to `commonMain` (#117). |
There was a problem hiding this comment.
There is a version mismatch between the pull request title (v0.6.1 release) and the changes in CHANGELOG.md, which are being added to the [0.6.0] section. If this is a v0.6.1 release, please create a new section for it and finalize the 0.6.0 entry. If it is a v0.6.0 release, the PR title should be updated for consistency.
…ered when there is a draft request to merge `main` into `release`
|
Remember to update CHANGELOG.md before merging. |
|
No description provided.