Implement TTY detection for Hono's logger middleware#4823
Open
Goldyvaiiii wants to merge 2 commits intohonojs:mainfrom
Open
Implement TTY detection for Hono's logger middleware#4823Goldyvaiiii wants to merge 2 commits intohonojs:mainfrom
Goldyvaiiii wants to merge 2 commits intohonojs:mainfrom
Conversation
Author
|
Adds TTY detection to getColorEnabled() to avoid emitting ANSI colors in non-TTY environments (e.g., CI, piped logs). Supports Node/Bun (process.stdout.isTTY) and Deno (stdout.isTerminal() with fallback). Preserves existing serverless behavior. Updates tests and adds TTY coverage. |
Member
Member
Author
|
Hey @yusukebe — thanks for the suggestion! I've updated this PR to align with the centralized TTY detection approach from #3017.
All tests are passing locally. Please let me know if this direction looks good or if you'd like any further adjustments. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the logger middleware always applies ANSI color codes regardless of whether
the output destination is a terminal. This causes garbled color escape sequences in
logs when output is piped to files, CI systems, or other non-TTY destinations.
This PR adds cross-runtime TTY detection to getColorEnabled() in src/utils/color.ts:
The NO_COLOR env variable continues to take highest precedence.