[WIP] feat: introduce Route Check Middleware#4703
Draft
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Bundle size check
Compiler Diagnostics (tsc)
Compiler Diagnostics (typescript-go)
Reported by octocov |
HTTP Performance Benchmark
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4703 +/- ##
==========================================
+ Coverage 91.43% 91.44% +0.01%
==========================================
Files 173 174 +1
Lines 11382 11396 +14
Branches 3302 3307 +5
==========================================
+ Hits 10407 10421 +14
Misses 974 974
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
4 tasks
|
Hi @yusukebe, thanks for working on this! I've opened #4714 as a follow-up optimization for this middleware. It introduces a WeakMap cache to store the result of the isMiddleware and findTargetHandler checks. Since handler identities are immutable at runtime, this avoids redundant recursive lookups for every request, optimizing the performance from O(depth) to O(1) while remaining safe for dynamic routes. Feel free to check it out :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve #4701
The author should do the following, if applicable
bun run format:fix && bun run lint:fixto format the code