feat: Enabled scrolling on listbox widgets#2642
Merged
hoffstadt merged 1 commit intohoffstadt:masterfrom May 4, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
name: Pull Request
about: Create a pull request to help us improve
title: feat: Enabled scrolling on listbox widgets
assignees: ''
Description:
Closes #2298.
This PR adds scrolling capabilities to
add_listbox, which enablesget/set_y_scroll, scrolling handlers, and so on. This is mostly useful for vertical scrolling since the listbox never shows a horizontal scrollbar (but it still can be scrolled horizontally either with OS gestures, including horizontal scroll wheel, or viaset_x_scroll).Concerning Areas:
In future, we'll probably need to add an option to show horizontal scrollbar. For now, proceeding without it to ship the fix sooner.
Work on this fix also revealed a possible bug in how the listbox behaves in disabled state - see the TODO added at the bottom of
draw_listbox. We'll need to address it at some point.