Skip to content

build: Fixed some warnings from compiler and PVS Studio #2601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hoffstadt merged 1 commit into from
Jan 27, 2026
Merged

build: Fixed some warnings from compiler and PVS Studio #2601

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/mvItemRegistry.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,7 +385,7 @@ MoveItemUp(mvItemRegistry& registry, mvUUID uuid)
{
for (auto& childset : parent->childslots)
{
for (auto it = childset.begin(), prev_it = childset.end(); it != childset.end(); ++it)
for (auto it = childset.begin(), prev_it = childset.begin(); it != childset.end(); ++it)
{
if (it->get() == item)
{
Expand Down
4 changes: 2 additions & 2 deletions src/mvLayoutWindow.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ DebugItem(const char* label, bool value) {

static void InfoHeader(const char* label) {
ImGui::NewLine();
ImGui::Text(label);
ImGui::Text("%s", label);
ImGui::Separator();
}

Expand Down Expand Up @@ -103,7 +103,7 @@ void mvLayoutWindow::renderTreeNode(std::shared_ptr<mvAppItem>& item)
{
is_labeled = false;
labelToShow = DearPyGui::GetEntityTypeString(item->type);
constexpr char* prefix = "mvAppItemType::";
constexpr const char* prefix = "mvAppItemType::";
// This is a cumbersome way to get string length, but it's the only way
// that provides a constexpr (note: strlen() is not a constexpr).
// Well, we could also do a `sizeof(prefix) - 1`...
Expand Down
Loading