Fix (mvThemes.cpp): Add missing ImGuiStyleVar_TabBarOverlineSize#2564
Merged
v-ein merged 1 commit intohoffstadt:masterfrom Oct 8, 2025
Merged
Conversation
…y for ImGuiStyleVar_TableAngledHeadersAngle to work) Add missing ImGuiStyleVar_TabBarOverlineSize (only for ImGuiStyleVar_TableAngledHeadersAngle to work). fixing an issue about: TableAngledHeaderAngle does not work outside of Style Editor (https://discord.com/channels/736279277242417272/1424799834006884483)
Collaborator
|
BTW this issue also affects several other styles. Here are all the styles that don't work in 2.0/2.1: |
Collaborator
|
Here's the test script I've come up with. import dearpygui.dearpygui as dpg
dpg.create_context()
dpg.configure_app(docking=True)
dpg.create_viewport(title=f"Test - {dpg.get_dearpygui_version()}", width=500, height=400)
with dpg.theme() as theme:
with dpg.theme_component():
dpg.add_theme_style(dpg.mvStyleVar_SelectableTextAlign, 1, 0.5)
dpg.add_theme_style(dpg.mvStyleVar_SeparatorTextPadding, 4, 20)
dpg.add_theme_style(dpg.mvStyleVar_SeparatorTextBorderSize, 8)
# This one isn't going to work anyway, see #2312
dpg.add_theme_style(dpg.mvStyleVar_DockingSeparatorSize, 16)
dpg.bind_theme(theme)
with dpg.window(label="Dock here", width=500, height=500):
# dpg.bind_item_theme(dpg.last_item(), theme)
dpg.add_selectable(label="Lorem ipsum", width=150)
dpg.add_separator(label="dolor sit")
dpg.add_text("amet")
with dpg.window(label="Dock me", width=300, height=150):
dpg.add_text("Dock me onto the other window\nto see the docking separator.")
dpg.setup_dearpygui()
dpg.show_viewport()
# In the correctly working version of DPG, styles listed in `theme` will be applied
# to the GUI right away, and any changes to them in the style editor will not affect
# anything.
dpg.show_style_editor()
# Some styles are only present in Dear ImGui's style editor, not in DearPyGui's one.
dpg.show_imgui_demo()
dpg.start_dearpygui()
dpg.destroy_context() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
name: Pull Request
about: Create a pull request to help us improve
title: 'Fix (mvThemes.cpp): Add missing ImGuiStyleVar_TabBarOverlineSize'
assignees: @hoffstadt
Description:
Add missing ImGuiStyleVar_TabBarOverlineSize (only for ImGuiStyleVar_TableAngledHeadersAngle to work).
fixing an issue about: TableAngledHeaderAngle does not work outside of Style Editor (https://discord.com/channels/736279277242417272/1424799834006884483)
Concerning Areas:
I was tinkering with TabBarOverlineSize in some other places (mvPyUtils.cpp, dearpygui.cpp), but it seem only work on docked windows, also seem imgui 1.91.8 improved it (DPG using 1.91.0).
So, this PR only for ImGuiStyleVar_TableAngledHeadersAngle to work.