Themes improvement#2473
Merged
hoffstadt merged 4 commits intohoffstadt:masterfrom Jan 26, 2026
Merged
Conversation
…to other unrelated components and thus hindering their deletion. Also, std::move in push_theme_components makes things a bit more efficient.
…tPtr on type==All components. This change both fixes an inefficiency (sometimes leading to errors) and simplifies the code. With this change, all_item_theme_component becomes useless, too.
This is needed to properly restore _specificComponentPtr back when there are multiple components with the same specificType.
Owner
|
Is this ready? |
Collaborator
Author
|
Techincally yes, it is ready. I've just added a minor change that should prevent potential undefined behavior (which currently would not happen anyway, it's just to make code more robust). I see on the Checks tab that the Windows build fails in ImPlot. It's not related to this PR but I think we need to fix it anyway. Will take a look a bit later. It builds fine on my local Windows machine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
name: Pull Request
about: Create a pull request to help us improve
title: Several fixes on theme internals
assignees: @hoffstadt
Description:
This PR is difficult to test as it fixes internal-looking issues within mvThemes.cpp.
all_item_theme_component(it is never really used by push/pop because ofmvAppItemType::Allconditions in them).Concerning Areas:
None.