Skip to content

fix(idle-poll): wake the network task unconditionally#2444

Open
cagatay-y wants to merge 1 commit into
hermit-os:mainfrom
cagatay-y:fix-idle-poll
Open

fix(idle-poll): wake the network task unconditionally#2444
cagatay-y wants to merge 1 commit into
hermit-os:mainfrom
cagatay-y:fix-idle-poll

Conversation

@cagatay-y
Copy link
Copy Markdown
Contributor

In order for the kernel to poll the NIC when idle as desired when the idle-poll feature is enabled, we need to wake the task unconditionally.

In order for the kernel to poll the NIC when idle as desired when the
idle-poll feature is enabled, we need to wake the task unconditionally.
@mkroening mkroening self-assigned this May 27, 2026
@mkroening mkroening self-requested a review May 27, 2026 16:14
Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark Results

Details
Benchmark Current: 79d8b7a Previous: ede71c0 Performance Ratio
startup_benchmark Build Time 103.78 s 99.20 s 1.05
startup_benchmark File Size 0.76 MB 0.76 MB 1.00
Startup Time - 1 core 0.91 s (±0.06 s) 0.94 s (±0.04 s) 0.97
Startup Time - 2 cores 0.93 s (±0.04 s) 0.96 s (±0.05 s) 0.97
Startup Time - 4 cores 0.94 s (±0.04 s) 0.96 s (±0.04 s) 0.98
multithreaded_benchmark Build Time 103.14 s 107.20 s 0.96
multithreaded_benchmark File Size 0.86 MB 0.86 MB 1.00
Multithreaded Pi Efficiency - 2 Threads 91.40 % (±14.36 %) 91.00 % (±14.55 %) 1.00
Multithreaded Pi Efficiency - 4 Threads 44.20 % (±6.98 %) 45.27 % (±7.73 %) 0.98
Multithreaded Pi Efficiency - 8 Threads 24.72 % (±3.72 %) 24.88 % (±3.26 %) 0.99
micro_benchmarks Build Time 93.01 s 92.81 s 1.00
micro_benchmarks File Size 0.86 MB 0.86 MB 1.00
Scheduling time - 1 thread 68.93 ticks (±4.30 ticks) 68.53 ticks (±3.92 ticks) 1.01
Scheduling time - 2 threads 39.94 ticks (±4.36 ticks) 39.67 ticks (±4.24 ticks) 1.01
Micro - Time for syscall (getpid) 2.97 ticks (±0.28 ticks) 2.95 ticks (±0.28 ticks) 1.01
Memcpy speed - (built_in) block size 4096 78560.69 MByte/s (±54327.93 MByte/s) 79590.12 MByte/s (±55157.77 MByte/s) 0.99
Memcpy speed - (built_in) block size 1048576 29809.68 MByte/s (±24352.38 MByte/s) 29900.58 MByte/s (±24427.92 MByte/s) 1.00
Memcpy speed - (built_in) block size 16777216 29157.00 MByte/s (±24085.32 MByte/s) 29198.54 MByte/s (±24141.87 MByte/s) 1.00
Memset speed - (built_in) block size 4096 78498.46 MByte/s (±54284.80 MByte/s) 79808.67 MByte/s (±55316.96 MByte/s) 0.98
Memset speed - (built_in) block size 1048576 30552.18 MByte/s (±24785.24 MByte/s) 30660.50 MByte/s (±24865.67 MByte/s) 1.00
Memset speed - (built_in) block size 16777216 29923.71 MByte/s (±24523.66 MByte/s) 29947.79 MByte/s (±24563.56 MByte/s) 1.00
Memcpy speed - (rust) block size 4096 70053.16 MByte/s (±48824.81 MByte/s) 71838.02 MByte/s (±50156.20 MByte/s) 0.98
Memcpy speed - (rust) block size 1048576 29885.41 MByte/s (±24340.08 MByte/s) 29850.23 MByte/s (±24412.52 MByte/s) 1.00
Memcpy speed - (rust) block size 16777216 28976.50 MByte/s (±23909.66 MByte/s) 29179.09 MByte/s (±24119.28 MByte/s) 0.99
Memset speed - (rust) block size 4096 70085.62 MByte/s (±48846.13 MByte/s) 72078.48 MByte/s (±50299.01 MByte/s) 0.97
Memset speed - (rust) block size 1048576 30655.94 MByte/s (±24791.75 MByte/s) 30581.94 MByte/s (±24812.57 MByte/s) 1.00
Memset speed - (rust) block size 16777216 29738.66 MByte/s (±24342.25 MByte/s) 29935.12 MByte/s (±24543.49 MByte/s) 0.99
alloc_benchmarks Build Time 86.23 s 85.84 s 1.00
alloc_benchmarks File Size 0.84 MB 0.84 MB 1.00
Allocations - Allocation success 100.00 % 100.00 % 1
Allocations - Deallocation success 100.00 % 100.00 % 1
Allocations - Pre-fail Allocations 100.00 % 100.00 % 1
Allocations - Average Allocation time 4834.64 Ticks (±1250.46 Ticks) 4581.75 Ticks (±1166.54 Ticks) 1.06
Allocations - Average Allocation time (no fail) 4834.64 Ticks (±1250.46 Ticks) 4581.75 Ticks (±1166.54 Ticks) 1.06
Allocations - Average Deallocation time 688.18 Ticks (±187.18 Ticks) 878.84 Ticks (±180.10 Ticks) 0.78
mutex_benchmark Build Time 88.66 s 101.79 s 0.87
mutex_benchmark File Size 0.87 MB 0.87 MB 1.00
Mutex Stress Test Average Time per Iteration - 1 Threads 13.18 ns (±0.82 ns) 13.22 ns (±0.73 ns) 1.00
Mutex Stress Test Average Time per Iteration - 2 Threads 16.02 ns (±1.09 ns) 19.06 ns (±1.33 ns) 0.84

This comment was automatically generated by workflow using github-action-benchmark.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants