bt-ui: Implement and polish Bigtrace asynchronous queries#5822
Draft
gignat-dev wants to merge 3 commits into
Draft
bt-ui: Implement and polish Bigtrace asynchronous queries#5822gignat-dev wants to merge 3 commits into
gignat-dev wants to merge 3 commits into
Conversation
This commit consolidates a series of architectural improvements and
UI/UX polish for the Bigtrace query interface.
Key changes include:
* Architecture: Replaces http_data_source with a centralized
BigtraceQueryClient and QueryRunner to better manage query lifecycles.
* DataGrid Integration: Implements server-side sorting (order_by),
filter encoding for Datagrid chips, and scroll-based pagination.
* UI/UX Polish: Introduces updated progress bars, improved duration
formatting, and displays post-filter row counts in the results toolbar.
* State Management: Fixes ephemeral tab state when switching pages and
optimizes query history refetching on sidebar toggles.
* Code Quality: Adds extensive unit testing across core query components.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| private queries = new Map<string, QueryExecution>(); | ||
|
|
||
| getOrCreate( | ||
| uuid: string, |
🎨 Perfetto UI Builds
|
Bigtrace UI Builds
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces comprehensive support for executing asynchronous
queries in the Bigtrace UI, along with a series of architectural
improvements and UX polish.
Key additions and improvements include:
manage long-running asynchronous Bigtrace queries.
QueryRunner to manage query lifecycles, separating state management
from the UI components.
scroll-based approach and implements server-side sorting (order_by)
and filter encoding for Datagrid chips.
status polling, and fixes ephemeral tab state when switching pages.
row counts, and improved duration formatting.
the data source, query client, and history storage.