trace_processor: Parse adreno_cmdbatch_retired/sync events#5817
trace_processor: Parse adreno_cmdbatch_retired/sync events#5817rossning92 wants to merge 1 commit into
Conversation
|
I'll try this out shortly. Give me a few days though - hopefully this is not in a rush. |
|
@batesj no rush many thanks for the help! |
|
@rossning92 I'm getting a build error: |
fbe508d to
cae15ed
Compare
|
@batesj My bad. I did a rebase on to main branch, but apparently some structure name changed. |
|
@rossning92 This is working much better! I think there's only one remaining issue where initial clipped events are interpreted wrong. Looks like if an event was clipped at the start of ftrace events (like there's only an end event with no begin event), this CL will turn it into an even that starts at the end time instead. You can see in this screenshot the start of ftrace events there's an offset GPU event in Ctx=25. In my kgsl query I get no event for that:
Is there a way to drop that instead when there's no begin event? |
Add custom parsing for kgsl adreno_cmdbatch_queue, adreno_cmdbatch_sync and adreno_cmdbatch_retired ftrace events to produce GPU timeline slices in the trace processor.
cae15ed to
5d0c9a9
Compare
|
@batesj thanks for trying it! Indeed, the initial clipped/drifted events are because they are not paired with I updated the PR and I'm pretty confident that it should now match the parity of your SQL query. On top of that, I also attached the process name to the track name (whenever Thanks so much again for such helpful feedback! |




Add custom parsing for kgsl adreno_cmdbatch_sync and adreno_cmdbatch_retired ftrace events to produce GPU timeline slices in the trace processor.

This is a rework of #5519 (reverted in #5793) which fixes the GPU event drift in the timeline by using per-cmdbatch sync points instead of a single global clock snapshot.
TODO: Pending validation if this PR fixes all drift issues that @batesj has observed on his end.
Test run result: