Skip to content

Switch from enhanced for-loop to indexed one to improve comprehension performance #999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Mar 30, 2026
+9 −6
Merged

Switch from enhanced for-loop to indexed one to improve comprehension performance #999

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions runtime/src/main/java/dev/cel/runtime/planner/NamespacedAttribute.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,8 +77,9 @@ public Object resolve(long exprId, GlobalResolver ctx, ExecutionFrame frame) {

if (partialVars != null) {
ImmutableList<CelAttributePattern> patterns = partialVars.unknowns();
for (Qualifier qualifier : qualifiers) {
attr = attr.qualify(CelAttribute.Qualifier.fromGeneric(qualifier.value()));
// Avoid enhanced for loop to prevent UnmodifiableIterator from being allocated
for (int i = 0; i < qualifiers.size(); i++) {
attr = attr.qualify(CelAttribute.Qualifier.fromGeneric(qualifiers.get(i).value()));
}

CelAttributePattern partialMatch = findPartialMatchingPattern(attr, patterns).orElse(null);
Expand Down Expand Up @@ -178,8 +179,9 @@ private static Object applyQualifiers(
Object value, CelValueConverter celValueConverter, ImmutableList<Qualifier> qualifiers) {
Object obj = celValueConverter.toRuntimeValue(value);

for (Qualifier qualifier : qualifiers) {
obj = qualifier.qualify(obj);
// Avoid enhanced for loop to prevent UnmodifiableIterator from being allocated
for (int i = 0; i < qualifiers.size(); i++) {
obj = qualifiers.get(i).qualify(obj);
}

return celValueConverter.maybeUnwrap(obj);
Expand Down
5 changes: 3 additions & 2 deletions runtime/src/main/java/dev/cel/runtime/planner/RelativeAttribute.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,9 @@ public Object resolve(long exprId, GlobalResolver ctx, ExecutionFrame frame) {

obj = celValueConverter.toRuntimeValue(obj);

for (Qualifier qualifier : qualifiers) {
obj = qualifier.qualify(obj);
// Avoid enhanced for loop to prevent UnmodifiableIterator from being allocated
for (int i = 0; i < qualifiers.size(); i++) {
obj = qualifiers.get(i).qualify(obj);
}

return celValueConverter.maybeUnwrap(obj);
Expand Down
Loading