feat: add WithInvocationID run option#815
Open
quoral wants to merge 1 commit into
Open
Conversation
Adds a RunOption that lets a caller pass an existing invocation ID into runner.Run. When set, the invocation context uses the supplied ID instead of generating a fresh one. Pure plumbing in this PR: the option is wired through runOptions and the InvocationContextParams. Callers that omit it keep the existing auto-generated behaviour.
2 tasks
|
@mazas-google tagging you 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
InvocationIDwas not able to be set from the callers of the ADK. This did not match the adk-python implementation. This has made us not being able to follow the resume functionality within the adk-python guide here.Solution:
This adds a RunOption that lets a caller pass an existing invocation ID into
runner.Run. When set, the invocation context uses the supplied ID
instead of generating a fresh one.
Testing Plan
Unit Tests:
Please include a summary of passed go test results.
Manual End-to-End (E2E) Tests:
I have started and run our adk-go Agent with these fixes, and ensured that there are no regressions in other behaviors.
Checklist