showcase: shared gradient layer + testimonials masonry fix#214
Closed
aryanmehrotra wants to merge 1 commit into
Closed
showcase: shared gradient layer + testimonials masonry fix#214aryanmehrotra wants to merge 1 commit into
aryanmehrotra wants to merge 1 commit into
Conversation
ShowcaseGradient is a small decorative orb layer (cyan + indigo,
matching the Hero's existing vocabulary). Drop it inside any
`relative overflow-x-clip` wrapper and three pointer-events-none
orbs distribute down the page at alternating sides.
Wired into the framework's pitch surfaces:
- homepage (replaces the inline orb cluster)
- /why-gofr, /comparison/*, /migrate/* via MarketingPage's new
opt-in `withGradient` prop
- /showcase (its custom layout doesn't use MarketingPage, so
it composes ShowcaseGradient directly)
Reading-mode pages keep the calm canvas they had — /faq, /learn
also use MarketingPage but don't pass withGradient. /docs/** and
the rest of the site are untouched.
Also fixes the testimonials masonry on narrow viewports
(`Reviews.jsx`): added `block break-inside-avoid w-full` to each
card and `gap-x-6` between columns. Without break-inside-avoid,
CSS multi-column layout was splitting tall cards across the
column boundary, rendering the two halves on top of each other.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR introduces a reusable decorative gradient layer for marketing/showcase surfaces and updates the testimonials masonry styling to prevent card overlap on narrower viewports. It fits the site’s marketing-page architecture by making the gradient opt-in for SEO landing layouts while keeping calmer reference pages unchanged.
Changes:
- Added a shared
ShowcaseGradientcomponent and wired it into the homepage, showcase page, and selectedMarketingPageroutes. - Extended
MarketingPagewith awithGradientprop so/why-gofr,/comparison/*, and/migrate/*can opt into the decorative layer. - Updated
Reviews.jsxmasonry card classes to avoid column splitting and add horizontal spacing.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
src/components/ShowcaseGradient.jsx |
New shared decorative orb layer used by marketing/showcase pages. |
src/components/Reviews.jsx |
Adjusts testimonial masonry/card classes to avoid split cards. |
src/components/MarketingPage.jsx |
Adds opt-in gradient support for SEO/marketing page layouts. |
src/components/HomePage.jsx |
Integrates the shared gradient into the homepage wrapper. |
src/app/why-gofr/layout.jsx |
Enables gradient for /why-gofr. |
src/app/showcase/page.jsx |
Adds the shared gradient to the showcase page layout. |
src/app/migrate/layout.jsx |
Enables gradient for /migrate/*. |
src/app/comparison/layout.jsx |
Enables gradient for /comparison/*. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+23
to
+24
| <div className="relative m-auto w-auto max-w-screen-2xl overflow-x-clip"> | ||
| <ShowcaseGradient /> |
| /> | ||
| <Image | ||
| aria-hidden="true" | ||
| className="pointer-events-none absolute -left-40 top-[80%] hidden select-none opacity-15 sm:block" |
Comment on lines
+17
to
+20
| // Why `unoptimized` is mandatory: the site builds with | ||
| // `output: 'export'`, which disables /_next/image. Without unoptimized, | ||
| // Next emits a /_next/image?url=... src that 404s in production and | ||
| // renders as a broken-image icon. |
3 tasks
Member
Author
|
Superseded by #215 — all commits from this branch are stacked there as part of a single QA-bundle PR. Closing without deleting the branch. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ShowcaseGradientcomponent — three pointer-events-none cyan+indigo orbs distributed down the page, matching the vocabulary the Hero already uses. Drop inside anyrelative overflow-x-clipwrapper./— replaces the page's inline orb cluster/why-gofr,/comparison/*,/migrate/*— via a new opt-inwithGradientprop onMarketingPage/showcase— composed directly into its custom layout/faq,/learnalso useMarketingPagebut don't passwithGradient./docs/**is untouched.Reviews.jsx: testimonials masonry was splitting tall cards across CSS-column boundaries on narrow viewports, rendering the two halves on top of each other. Addedblock break-inside-avoid w-fullto each card andgap-x-6between columns.Test plan
npx next buildsucceeds (locally verified before commit)./,/why-gofr,/comparison,/comparison/gofr-vs-gin,/migrate,/migrate/from-gin,/showcase,/faq,/learn)./faqand/learn.🤖 Generated with Claude Code