Skip to content

Add support for running glb-director on ubuntu noble#181

Draft
mpenny-github wants to merge 51 commits into
masterfrom
mpenny_noble_build
Draft

Add support for running glb-director on ubuntu noble#181
mpenny-github wants to merge 51 commits into
masterfrom
mpenny_noble_build

Conversation

@mpenny-github
Copy link
Copy Markdown
Contributor

@mpenny-github mpenny-github commented Apr 1, 2026

The primary change from the PR is to add build and runtime support for glb-director on ubuntu noble.
The existing test suite is designed to run on a vagrant VM. This PR also updates the test suite to run inside a docker container on github actions.

  1. Update .github/workflows/ci.yml to run the CI builds for ubuntu noble and focal in parallel.
  2. Add a new .github/workflows/test.yml to run the tests suite that currently runs in a vagrant VM in a container on github actions.
  3. Update script/helpers/folding.sh so that it using github action style grouping for messages rather than the legacy janky (?) format.
  4. Update script/cibuild-create-packages to take an argument for the distro that it will be building for.
  5. Remove script/cibuild-create-packages-focal in favor of the parameterized version (4.)
  6. Update script/Dockerfile.focal to ensure that clang-tools are included.
  7. Create script/Dockerfile.noble for builds on ubuntu noble.
  8. Create a platform agnostic script/test that detects and uses the correct version of scan-build.
  9. Source code and makefile changes to add support for running on ubuntu noble.

Comment thread script/cibuild-create-packages-noble Outdated

begin_fold "Preparing Docker build environment"
(
docker build -t glb-director-build-noble -f script/Dockerfile.noble script
Copy link
Copy Markdown
Contributor

@fjaeckel fjaeckel Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
docker build -t glb-director-build-noble -f script/Dockerfile.noble script
docker build -t glb-director-build -f script/Dockerfile.noble script

instead of copying the whole script, can we please move towards a parameterized version of it to pass the OS flavor as a argument and make this more dynamic?

Copy link
Copy Markdown
Contributor

@fjaeckel fjaeckel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please move towards a parameterised version of cibuild for choosing the OS flavor

Comment thread .github/workflows/test.yml Fixed
Comment thread .github/workflows/test.yml Fixed
Comment thread .github/workflows/test.yml Fixed
Comment thread .github/workflows/test.yml Fixed
Comment thread .github/workflows/test.yml Fixed
Comment thread .github/workflows/test.yml Fixed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants