Skip to content

[code-simplifier] refactor: remove redundant footer variable in handle_noop_message (#23284)#23318

Merged
pelikhan merged 1 commit intomainfrom
code-simplifier/remove-redundant-footer-variable-fafe79a47b33d0aa
Mar 28, 2026
Merged

[code-simplifier] refactor: remove redundant footer variable in handle_noop_message (#23284)#23318
pelikhan merged 1 commit intomainfrom
code-simplifier/remove-redundant-footer-variable-fafe79a47b33d0aa

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

Simplifies code introduced in #23284 by removing an unnecessary intermediate variable.

Files Simplified

  • actions/setup/js/handle_noop_message.cjs — removed footer intermediate variable

Improvement Made

In ensureAgentRunsIssue, the footer variable was assigned from generateFooterWithExpiration(...) and then immediately assigned to parentBody:

// Before
const footer = generateFooterWithExpiration({ ... });
const parentBody = footer;

This intermediate step adds no value. The simplification assigns directly to parentBody:

// After
const parentBody = generateFooterWithExpiration({ ... });

Changes Based On

Recent changes from:

Testing

  • ✅ Linting passes (make lint-cjs)
  • ✅ Build succeeds (make build)
  • ✅ No functional changes — behavior is identical

References: §23678839951

Generated by Code Simplifier ·

  • expires on Mar 29, 2026, 6:02 AM UTC

…p_message

Simplify ensureAgentRunsIssue by directly assigning the result of
generateFooterWithExpiration to parentBody, eliminating the unnecessary
footer intermediate variable.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@pelikhan pelikhan marked this pull request as ready for review March 28, 2026 10:38
Copilot AI review requested due to automatic review settings March 28, 2026 10:38
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Simplifies ensureAgentRunsIssue by removing a redundant intermediate variable when generating the issue body for the no-op runs parent issue.

Changes:

  • Inline generateFooterWithExpiration(...) result directly into parentBody (removes unnecessary footer variable).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@pelikhan pelikhan merged commit 0c14ba2 into main Mar 28, 2026
64 checks passed
@pelikhan pelikhan deleted the code-simplifier/remove-redundant-footer-variable-fafe79a47b33d0aa branch March 28, 2026 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants