add env param to command type#20
Merged
Merged
Conversation
Contributor
Author
|
bugbot run |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit f87cb20. Configure here.
Contributor
Author
|
bugbot run |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 7d9fba3. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Note
Medium Risk
Introduces environment-variable injection into both command execution and agent invocation, which can change runtime behavior and has potential security/secret-handling implications if misused. Scope spans both the TypeScript runtime protocol/types and the Python client serialization/tests.
Overview
Adds environment variable plumbing end-to-end:
InvocationMessagenow carriesagent_env(forwarded toAgentInvocation.env), andCommand/CommandInterfacenow support per-commandenv.Updates the TypeScript runtime to merge command
envon top ofprocess.envwhen spawning commands and to pass invocationagent_envinto the Claude handler’s SDK options; adds/updates unit tests accordingly. Updates the Python client/types/docs/tests to serialize these new fields and demonstrate usage inquery()andexecute_commands().Reviewed by Cursor Bugbot for commit 7d9fba3. Bugbot is set up for automated code reviews on this repo. Configure here.