Switch to pnpm#149
Open
schtibe wants to merge 1 commit into
Open
Conversation
Contributor
|
Hey @schtibe, thanks for the update. Since it's a small project with very few dependencies, I don't see other reason to implement it other than keeping it consistent with other projects. If you're familiar with it, I'm not against it. The 'shiki' package problem is probably because it's a dependency of vite-press, with npm we can directly use it but with pnpm we need to add to the packages. Can you do that please? |
asteiner-swisstopo
approved these changes
May 13, 2026
Contributor
asteiner-swisstopo
left a comment
asteiner-swisstopo
left a comment
There was a problem hiding this comment.
Hard to judge for me what is better but I like consistency - so go for it 👍
And yes, don't forget to make a corresponding change in CodeBuild..
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With all the other frontend projects we're using pnpm instead of npm these days. I suggest switching here, too!
WDYT?
It should not be much more than just typing
pnpminstead ofnpmin the CLI.Also, I needed to add the package 'shiki' in my case, it seemed to be missing (but maybe that's because pnpm behaves slightly different?)
If you're OK with this, I will have to update the codebuild project to use
pnpmas well before we can merge thisTest link