bitbardd#5
Merged
Merged
Conversation
geersch
force-pushed
the
feat/bitbardd
branch
2 times, most recently
from
7d75280 to
ed424ff
Compare
… on repeated alerts NSHostingView and NSHostingController both leave SwiftUI attribute-graph objects in the Objective-C autorelease pool. When a second alert is shown before the first window's pool drains, objc_release dereferences a stale pointer into the first view's deallocated SwiftUI graph -> EXC_BAD_ACCESS in NSApp.run(). Replace SwiftUI with a plain NSView (PillView) that draws the pill using CALayer properties and an NSTextField label. No autorelease pool involvement, no SwiftUI graph lifetime issues. Also switch win.close() to win.orderOut(nil) so the window is hidden before the strong reference is removed from activeWindows, preventing a brief window where the pool could hold a dangling pointer to a deallocated NSWindow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.