Skip to content

fix: bump mirror pin to include snapshot-fetch fix#4044

Open
sanity wants to merge 1 commit into
mainfrom
bump-mirror-pin-snapshot-fix
Open

fix: bump mirror pin to include snapshot-fetch fix#4044
sanity wants to merge 1 commit into
mainfrom
bump-mirror-pin-snapshot-fix

Conversation

@sanity
Copy link
Copy Markdown
Collaborator

@sanity sanity commented May 7, 2026

Problem

The five most recent Mirror to Freenet runs against this repo have all failed with:

```
fatal: bad object a6afd44c68bad8bd12ecb91479dbdad9d25a06fc
! [remote rejected] main -> main (git rev-list failed: exit status: 128)
```

Root cause was in the reusable workflow at the previously-pinned SHA: in snapshot mode the fresh orphan commit's local repo has no ancestor objects in common with the receiver's tip, so the helper's git rev-list ^<remote-tip> <new-tip> bails.

Solution

freenet/freenet-git#20 (already merged) added git fetch freenet "\$BRANCH" before the push so the remote tip is pulled into local objects. This PR bumps our pinned SHA to that fix.

Testing

Underlying fix verified end-to-end locally before merging freenet-git#20. Demo freenet:3GEERif5ihbf/freenet-core was re-published manually to b2a8836 while diagnosing — fresh git clone against the live gateway returns 523 files. Next push to main after this lands will exercise the fixed workflow against the established tip.

Fixes

Unblocks Mirror to Freenet workflow on this repo.

[AI-assisted - Claude]

## Problem

The five most recent `Mirror to Freenet` runs against this repo
have all failed with:

  fatal: bad object a6afd44c68bad8bd12ecb91479dbdad9d25a06fc
  ! [remote rejected] main -> main (git rev-list failed: exit status: 128)

Root cause is in the reusable workflow at the previously-pinned SHA:
in snapshot mode the fresh orphan commit's local repo has no
ancestor objects in common with the receiver's tip, so the helper's
`git rev-list ^<remote-tip> <new-tip>` bails.

## Solution

freenet/freenet-git#20 added `git fetch freenet "$BRANCH"` before
the push so the remote tip is pulled into local objects. This PR
bumps our pinned SHA to that fix.

History mode (used by freenet-stdlib) was never affected by this
bug, so the corresponding bump there is not needed -- but the
sibling caller will pick up the fix opportunistically when its pin
is next rev'd.

## Testing

Verified the underlying fix end-to-end locally before merging
freenet-git#20: a fresh orphan repo with `git fetch freenet main`
followed by `git push freenet +main:main` succeeds against the
live demo gateway. The freenet-core demo was re-published manually
to `b2a8836` while diagnosing the failure; once this lands, the
next push to main will exercise the fixed workflow against the
established remote tip.

## Fixes

Unblocks the broken `Mirror to Freenet` runs on this repo.

[AI-assisted - Claude]

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@sanity sanity enabled auto-merge May 7, 2026 14:38
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 7, 2026

Rule Review: Clean CI workflow pin bump

Rules checked: git-workflow.md
Files reviewed: 1 (.github/workflows/mirror-to-freenet.yml)

The diff is a single-line SHA bump for a pinned external GitHub Actions workflow. No Rust code was changed.

Checks performed:

  • Commit title fix: bump mirror pin to include snapshot-fetch fix — follows conventional commits, under 72 characters ✓
  • No Rust code changed → cargo fmt/clippy/test requirements don't apply ✓
  • No new #[ignore] tests, no cleanup exemptions, no production .unwrap()
  • fix: prefix is valid; build: would also be semantically appropriate for a CI config change, but fix: is acceptable since it corrects broken behavior in the workflow ✓
  • Regression test rule: this is a CI workflow pin update, not a code bug — there is no meaningful test that could catch a stale SHA in a reusable workflow reference, so the fix:-requires-test rule does not apply here ✓

Warnings

None.

Info

None.

No rule violations detected.


Rule review against .claude/rules/. WARNING findings block merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant