Skip to content

feat(a11y): add accessibility improvements to login and drawer #1786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arricsekhon wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat(a11y): add accessibility improvements to login and drawer #1786

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d6b5a7e
feat: add accessibility improvements to login screen
arricsekhon Apr 22, 2026
e4f0b4b
feat: add accessibility improvements to drawer navigation
arricsekhon Apr 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
297 changes: 184 additions & 113 deletions mobile-app/lib/ui/views/login/native_login_view.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,29 +62,42 @@ class NativeLoginView extends StatelessWidget {
child: Container(
constraints: const BoxConstraints(minHeight: 50),
margin: const EdgeInsets.all(16),
child: ElevatedButton(
style: buttonStyle,
onPressed: () {
model.auth.login(context, 'google-oauth2');
},
child: Row(
mainAxisAlignment: MainAxisAlignment.start,
children: [
Image.asset(
'assets/images/google-logo.png',
height: 25,
width: 25,
),
Expanded(
child: Padding(
padding: const EdgeInsets.all(8.0),
child: Text(
context.t.login_with_google,
style: textStyle,
child: Tooltip(
message: context.t.login_with_google,
child: ElevatedButton(
style: buttonStyle,
onPressed: () {
model.auth.login(context, 'google-oauth2');
},
child: Semantics(
button: true,
enabled: true,
label: context.t.login_with_google,
child: Row(
mainAxisAlignment: MainAxisAlignment.start,
children: [
Semantics(
image: true,
label: 'Google logo',
child: Image.asset(
'assets/images/google-logo.png',
height: 25,
width: 25,
semanticLabel: 'Google logo',
),
),
),
Expanded(
child: Padding(
padding: const EdgeInsets.all(8.0),
child: Text(
context.t.login_with_google,
style: textStyle,
),
),
),
],
),
],
),
),
),
),
Expand All @@ -97,29 +110,42 @@ class NativeLoginView extends StatelessWidget {
child: Container(
constraints: const BoxConstraints(minHeight: 50),
margin: const EdgeInsets.all(16),
child: ElevatedButton(
style: buttonStyle,
onPressed: () {
model.auth.login(context, 'github');
},
child: Row(
mainAxisAlignment: MainAxisAlignment.start,
children: [
Image.asset(
'assets/images/github-logo.png',
height: 25,
width: 25,
),
Expanded(
child: Padding(
padding: const EdgeInsets.all(8.0),
child: Text(
context.t.login_with_github,
style: textStyle,
child: Tooltip(
message: context.t.login_with_github,
child: ElevatedButton(
style: buttonStyle,
onPressed: () {
model.auth.login(context, 'github');
},
child: Semantics(
button: true,
enabled: true,
label: context.t.login_with_github,
child: Row(
mainAxisAlignment: MainAxisAlignment.start,
children: [
Semantics(
image: true,
label: 'GitHub logo',
child: Image.asset(
'assets/images/github-logo.png',
height: 25,
width: 25,
semanticLabel: 'GitHub logo',
),
),
),
Expanded(
child: Padding(
padding: const EdgeInsets.all(8.0),
child: Text(
context.t.login_with_github,
style: textStyle,
),
),
),
],
),
],
),
),
),
),
Expand All @@ -132,29 +158,42 @@ class NativeLoginView extends StatelessWidget {
child: Container(
margin: const EdgeInsets.all(16),
constraints: const BoxConstraints(minHeight: 50),
child: ElevatedButton(
style: buttonStyle,
onPressed: () {
model.auth.login(context, 'apple');
},
child: Row(
mainAxisAlignment: MainAxisAlignment.start,
children: [
Image.asset(
'assets/images/apple-logo.png',
height: 25,
width: 25,
),
Expanded(
child: Padding(
padding: const EdgeInsets.all(8.0),
child: Text(
context.t.login_with_apple,
style: textStyle,
child: Tooltip(
message: context.t.login_with_apple,
child: ElevatedButton(
style: buttonStyle,
onPressed: () {
model.auth.login(context, 'apple');
},
child: Semantics(
button: true,
enabled: true,
label: context.t.login_with_apple,
child: Row(
mainAxisAlignment: MainAxisAlignment.start,
children: [
Semantics(
image: true,
label: 'Apple logo',
child: Image.asset(
'assets/images/apple-logo.png',
height: 25,
width: 25,
semanticLabel: 'Apple logo',
),
),
),
Expanded(
child: Padding(
padding: const EdgeInsets.all(8.0),
child: Text(
context.t.login_with_apple,
style: textStyle,
),
),
),
],
),
],
),
),
),
),
Expand All @@ -164,34 +203,46 @@ class NativeLoginView extends StatelessWidget {
buildDivider(),
Container(
padding: const EdgeInsets.all(16),
child: TextFormField(
child: Semantics(
textField: true,
label: context.t.email,
enabled: !model.showOTPfield,
controller: model.emailController,
keyboardType: TextInputType.emailAddress,
decoration: InputDecoration(
hintText: context.t.email,
border: const OutlineInputBorder(
borderSide: BorderSide(width: 2, color: Colors.white),
child: TextFormField(
enabled: !model.showOTPfield,
controller: model.emailController,
keyboardType: TextInputType.emailAddress,
decoration: InputDecoration(
labelText: context.t.email,
hintText: context.t.email,
border: const OutlineInputBorder(
borderSide: BorderSide(width: 2, color: Colors.white),
),
),
),
),
),
model.showOTPfield
? Container(
padding: const EdgeInsets.all(16),
child: TextFormField(
autofocus: model.showOTPfield,
controller: model.otpController,
keyboardType: TextInputType.number,
decoration: InputDecoration(
hintText: context.t.email_enter_sign_in_code,
errorText: model.incorrectOTP
? context.t.email_invalid_code
: null,
errorMaxLines: 5,
border: const OutlineInputBorder(
borderSide:
BorderSide(width: 2, color: Colors.white),
child: Semantics(
textField: true,
label: context.t.email_enter_sign_in_code,
enabled: true,
child: TextFormField(
autofocus: model.showOTPfield,
controller: model.otpController,
keyboardType: TextInputType.number,
decoration: InputDecoration(
labelText: context.t.email_enter_sign_in_code,
hintText: context.t.email_enter_sign_in_code,
errorText: model.incorrectOTP
? context.t.email_invalid_code
: null,
errorMaxLines: 5,
border: const OutlineInputBorder(
borderSide:
BorderSide(width: 2, color: Colors.white),
),
),
),
),
Expand All @@ -203,23 +254,31 @@ class NativeLoginView extends StatelessWidget {
Expanded(
child: Container(
margin: const EdgeInsets.all(16),
child: ElevatedButton(
style: ctaButtonStyle.copyWith(
padding: const WidgetStatePropertyAll(
EdgeInsets.symmetric(vertical: 8),
child: Tooltip(
message: 'Submit and sign in to freeCodeCamp',
child: ElevatedButton(
style: ctaButtonStyle.copyWith(
padding: const WidgetStatePropertyAll(
EdgeInsets.symmetric(vertical: 8),
),
),
),
onPressed: model.otpFieldIsValid
? () {
model.verifyOTP(context);
}
: null,
child: Text(
'Submit and sign in to freeCodeCamp',
style: TextStyle(
fontSize: 20,
onPressed: model.otpFieldIsValid
? () {
model.verifyOTP(context);
}
: null,
child: Semantics(
button: true,
enabled: model.otpFieldIsValid,
label: 'Submit and sign in to freeCodeCamp',
child: Text(
'Submit and sign in to freeCodeCamp',
style: TextStyle(
fontSize: 20,
),
textAlign: TextAlign.center,
),
),
textAlign: TextAlign.center,
),
),
),
Expand All @@ -229,27 +288,39 @@ class NativeLoginView extends StatelessWidget {
child: Container(
margin: const EdgeInsets.all(16),
constraints: const BoxConstraints(minHeight: 50),
child: ElevatedButton(
style: ctaButtonStyle,
onPressed: model.emailFieldIsValid
? () {
model.sendOTPtoEmail();
}
: null,
child: Padding(
padding: const EdgeInsets.all(8.0),
child: Align(
child: Text(
context.t.email_submit_code,
style: TextStyle(
fontSize: 20,
child: Tooltip(
message: context.t.email_submit_code,
child: ElevatedButton(
style: ctaButtonStyle,
onPressed: model.emailFieldIsValid
? () {
model.sendOTPtoEmail();
}
: null,
child: Semantics(
button: true,
enabled: model.emailFieldIsValid,
label: context.t.email_submit_code,
child: Padding(
padding: const EdgeInsets.all(8.0),
child: Align(
child: Text(
context.t.email_submit_code,
style: TextStyle(
fontSize: 20,
),
textAlign: TextAlign.center,
),
),
textAlign: TextAlign.center,
),
),
),
),
),
)
),
),
),
),
],
),
Expand Down
Loading