fix(challenge): use headless in-app webview for test runner#1781
Merged
Nirajn2311 merged 2 commits intoMay 5, 2026
Merged
Conversation
This was referenced Apr 20, 2026
Nirajn2311
reviewed
Apr 25, 2026
Nirajn2311
reviewed
Apr 25, 2026
| await _babelWebView.dispose(); | ||
| await _localhostServer.close(); | ||
| if (_webViewsClosed) return; | ||
| _webViewsClosed = true; |
Member
There was a problem hiding this comment.
Better to set this after the webviews are closed and not before
Member
|
I'm gonna miss the test runner been a pixel on the screen 😆 |
Nirajn2311
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
InAppWebViewwith aHeadlessInAppWebViewChallengeViewModellifecycleWhy
The challenge runner depended on a hidden rendered widget instead of a true headless runtime, which made lifecycle handling more fragile.
Validation
flutter analyze lib/ui/views/learn/challenge/challenge_view.dart lib/ui/views/learn/challenge/challenge_viewmodel.dart