Skip to content

ci: skip redundant test run during publish#645

Merged
FBumann merged 1 commit intomainfrom
ci/simplify-publish
Mar 24, 2026
Merged

ci: skip redundant test run during publish#645
FBumann merged 1 commit intomainfrom
ci/simplify-publish

Conversation

@FBumann
Copy link
Copy Markdown
Member

@FBumann FBumann commented Mar 24, 2026

Summary

  • Remove the test job from publish.yaml — tests already pass on the PR and on the push-to-main trigger before publish runs
  • Remove workflow_call trigger from tests.yaml (no longer needed)

This cuts ~10 min of redundant CI time from every release.

Notes

Branch protection with required status checks should also be configured for main to ensure tests always pass before merging. This is a GitHub settings change (rulesets), not a workflow change.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Removed test job from publish workflow, allowing build to execute directly without test execution dependency
    • Removed workflow_call trigger from tests workflow, preventing external workflow invocations

Tests already pass on the PR and on push-to-main before publish is
triggered, so re-running the full suite in the publish workflow is
unnecessary. Remove the test job from publish.yaml and the
workflow_call trigger from tests.yaml.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 24, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 11738b1d-c990-49ea-a2dd-4cbba71fa50d

📥 Commits

Reviewing files that changed from the base of the PR and between 15aca5d and c44de76.

📒 Files selected for processing (2)
  • .github/workflows/publish.yaml
  • .github/workflows/tests.yaml
💤 Files with no reviewable changes (2)
  • .github/workflows/tests.yaml
  • .github/workflows/publish.yaml

📝 Walkthrough

Walkthrough

The changes remove the test job invocation from the publish workflow and eliminate the workflow_call trigger from the tests workflow. The build job now executes directly without awaiting test completion, and other workflows can no longer reuse the tests workflow as a callable action.

Changes

Cohort / File(s) Summary
Workflow Job Dependencies
.github/workflows/publish.yaml
Removed test job invocation and its dependency declaration, decoupling test execution from the publish pipeline.
Reusable Workflow Trigger
.github/workflows/tests.yaml
Removed workflow_call trigger, preventing external workflows from calling this workflow as a reusable action.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Poem

🐰 The tests once guarded the publish gate,
But now the build needs not to wait,
With workflows freed from tangled chains,
The pipeline flows through simpler lanes,
Hop on, dear code, without the test restraint!

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is missing several required template sections: Type of Change, Related Issues, Testing, and Checklist. Only the Summary and Notes sections are provided. Complete the missing template sections: specify Type of Change, add Related Issues if applicable, confirm testing status, and verify all checklist items.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title 'ci: skip redundant test run during publish' directly and concisely summarizes the main change: removing the redundant test job from the publish workflow to optimize CI time.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ci/simplify-publish

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@FBumann FBumann merged commit 103be48 into main Mar 24, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant