Clean up resource alloc#5892
Open
ShadowCurse wants to merge 3 commits into
Open
Conversation
ShadowCurse
force-pushed
the
clean_up_resource_alloc
branch
from
6853802 to
30031eb
Compare
This wrapper was used only once in the code and it generally does not follow the patter of using underlying allocators directly like the rest of the code does. The alternative to removing this is to do a exact opposite and find all places where allocators are used directly and make them use wrappers. This will not provide any benefits since wrappers have no logic in them and will only increase the line count and indirection overhead. Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
Following same logic from previous commit, remove this wrapper as well. Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
Following same logic from previous commit, remove this wrapper as well. Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
ShadowCurse
force-pushed
the
clean_up_resource_alloc
branch
from
30031eb to
8eb5186
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5892 +/- ##
==========================================
- Coverage 82.90% 82.89% -0.01%
==========================================
Files 277 277
Lines 30053 30029 -24
==========================================
- Hits 24914 24892 -22
+ Misses 5139 5137 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Remove some redundant functions from ResourceAllocator since most of the code accesses it's members directly anyway.
Reason
Less code
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkbuild --allto verify that the PR passesbuild checks on all supported architectures.
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.