vmm: interrupts: fix: add Drop for MsixVectorGroup#5890
Open
ShadowCurse wants to merge 1 commit into
Open
Conversation
ShadowCurse
force-pushed
the
clean_up_irqs
branch
2 times, most recently
from
b7de343 to
7073f60
Compare
Currently without Drop on MsixVectorGroup destroying devices during hot-unplug leaks interrupt ids because there is no code to clean them up. Implementing Drop on MsixVectorGroup is the simplest way to fix this issue. Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
ShadowCurse
force-pushed
the
clean_up_irqs
branch
from
7073f60 to
4711b37
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5890 +/- ##
=======================================
Coverage 82.90% 82.90%
=======================================
Files 277 277
Lines 30053 30075 +22
=======================================
+ Hits 24914 24935 +21
- Misses 5139 5140 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Currently without Drop on MsixVectorGroup destroying devices during hot-unplug leaks interrupt ids because there is no code to clean them up. Implementing Drop on MsixVectorGroup is the simplest way to fix this issue.
Reason
Don't leak irqs
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkbuild --allto verify that the PR passesbuild checks on all supported architectures.
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.