Use guest kernel 6.1 as default for tests where only a single kernel is tested#5732
Open
Manciukic wants to merge 5 commits into
Open
Use guest kernel 6.1 as default for tests where only a single kernel is tested#5732Manciukic wants to merge 5 commits into
Manciukic wants to merge 5 commits into
Conversation
Manciukic
force-pushed
the
default-guest-kernel-6.1
branch
from
f4230ad to
7431683
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5732 +/- ##
=======================================
Coverage 82.90% 82.90%
=======================================
Files 277 277
Lines 30053 30053
=======================================
Hits 24914 24914
Misses 5139 5139
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Manciukic
force-pushed
the
default-guest-kernel-6.1
branch
from
7431683 to
0e712e1
Compare
Manciukic
force-pushed
the
default-guest-kernel-6.1
branch
from
0e712e1 to
2680340
Compare
JamesC1305
previously approved these changes
May 15, 2026
Contributor
JamesC1305
left a comment
JamesC1305
left a comment
There was a problem hiding this comment.
LGTM overall. One small thing not directly related to your changes
|
|
||
| vmfcty = MicroVMFactory(bin_dir) | ||
| kernel_dbg = guest_kernel_linux_6_1.parent / "debug" / guest_kernel_linux_6_1.name | ||
| kernel_dbg = guest_kernel_default.parent / "debug" / guest_kernel_default.name |
Contributor
There was a problem hiding this comment.
kinda unrelated, but I think we have a fixture for 6.1 debug kernel. Could we use that instead of this?
Use the existing guest_kernel_6_1_debug fixture instead of manually constructing the debug kernel path from the kernel fixture. Signed-off-by: Riccardo Mancini <mancio@amazon.com>
Introduce a new fixture used by tests that don't care about the kernel version. This will make it easier to switch the default version in the next commits. Signed-off-by: Riccardo Mancini <mancio@amazon.com>
Alias guest_kernel_6_1_debug as guest_kernel_default_debug and update uvm_plain_debug and test_gdb to use it. Signed-off-by: Riccardo Mancini <mancio@amazon.com>
We expect most customers to use 6.1 rather than 5.10 nowadays. Signed-off-by: Riccardo Mancini <mancio@amazon.com>
As now uvm_plain is 6.1, drop uvm_plain_6_1 and use uvm_plain directly in those tests. No changes to the tests. Signed-off-by: Riccardo Mancini <mancio@amazon.com>
Manciukic
force-pushed
the
default-guest-kernel-6.1
branch
from
2680340 to
b179fc1
Compare
JamesC1305
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Switch tests that use
uvm_plainand other tests manually setting to 5.10 to use 6.1Reason
These tests don't care about the underlying kernel. Move them to the latest (and most widely used) one.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkbuild --allto verify that the PR passesbuild checks on all supported architectures.
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.