Skip to content

feat: append korean names#3742

Closed
i-am-a-dolphin wants to merge 1 commit intofaker-js:nextfrom
i-am-a-dolphin:patch-1
Closed

feat: append korean names#3742
i-am-a-dolphin wants to merge 1 commit intofaker-js:nextfrom
i-am-a-dolphin:patch-1

Conversation

@i-am-a-dolphin
Copy link
Copy Markdown

@i-am-a-dolphin i-am-a-dolphin requested a review from a team as a code owner February 15, 2026 05:20
@netlify
Copy link
Copy Markdown

netlify bot commented Feb 15, 2026

Deploy Preview for fakerjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit c16d76b
🔍 Latest deploy log https://app.netlify.com/projects/fakerjs/deploys/69915784328d520008c49569
😎 Deploy Preview https://deploy-preview-3742.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@ST-DDT
Copy link
Copy Markdown
Member

ST-DDT commented Feb 25, 2026

Hi @i-am-a-dolphin ,

Faker usually limits lists of names to ~1k entries to save memory/disk space a bit.
Is there a reason why you would add all names you have obtained prgrammatically?
(if the current set needs to be refreshed, then thats a valid reason, we should just stick to ~1k names)

Also, have you checked whether that particular source may be subject to copyright/ownership issues?
(the names itself aren't copyright-able, but specific collections might be without own transformation)

@ST-DDT ST-DDT added c: locale Permutes locale definitions m: person Something is referring to the person module p: 1-normal Nothing urgent labels Feb 25, 2026
@ST-DDT
Copy link
Copy Markdown
Member

ST-DDT commented Apr 6, 2026

@i-am-a-dolphin Are you still interested in this PR?

@ST-DDT ST-DDT marked this pull request as draft April 6, 2026 17:40
@ST-DDT
Copy link
Copy Markdown
Member

ST-DDT commented Apr 14, 2026

This PR appears to have gotten stale. If you are stil interested in this please let us know and we can reopen this one.

@ST-DDT ST-DDT closed this Apr 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: locale Permutes locale definitions m: person Something is referring to the person module p: 1-normal Nothing urgent

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants