Skip to content

Fix controlled date/time input reset behavior#36471

Open
LeSingh1 wants to merge 2 commits into
facebook:mainfrom
LeSingh1:fix-ios-time-input-reset
Open

Fix controlled date/time input reset behavior#36471
LeSingh1 wants to merge 2 commits into
facebook:mainfrom
LeSingh1:fix-ios-time-input-reset

Conversation

@LeSingh1
Copy link
Copy Markdown

Summary

Fixes #23299.

For controlled date/time-style inputs, React was syncing defaultValue from value on every update. On iOS Safari/Chrome, the native Reset/Clear button can reset the current value back to defaultValue. Because React kept defaultValue synced to the current value, Reset could become a no-op from React’s value tracking perspective, causing React’s synthetic onChange to be suppressed.

This change preserves the initial defaultValue setup from initInput, but skips later defaultValue syncing from value for date/time-style input types. This allows reset behavior to produce a real value change while keeping controlled value updates intact.

How did you test this change?

yarn prettier
yarn linc
yarn flow dom-node
node ./scripts/jest/jest-cli.js ReactDOMInput-test
node ./scripts/jest/jest-cli.js ChangeEventPlugin

Added a regression test for controlled time inputs to verify that defaultValue is not resynced from value after updates.

@meta-cla
Copy link
Copy Markdown

meta-cla Bot commented May 14, 2026

Hi @LeSingh1!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@LeSingh1
Copy link
Copy Markdown
Author

Signed the CLA, please re-check.

@LeSingh1
Copy link
Copy Markdown
Author

@meta-cla check

@meta-cla meta-cla Bot added the CLA Signed label May 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reset button on iOS time input does not return correct event value

1 participant