[compiler] Preserve JSX pragmas before generated imports#36465
Open
yudin-s wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #36460.
React Compiler adds a runtime import for compiled functions. When a source file starts with a JSX pragma such as
@jsxImportSource, inserting that runtime import at the very start of the program moves the pragma after a code statement in the generated output. Downstream JSX transforms such as Oxc, SWC, and TypeScript only honor these pragmas before code statements.This preserves leading JSX pragma comments by moving them onto the first generated compiler import before inserting it. Non-JSX leading comments are left on the original first statement, which avoids changing existing compiler fixture output for test-only config comments.
How did you test this change?
corepack yarn prettier --check packages/babel-plugin-react-compiler/src/Entrypoint/Imports.ts packages/babel-plugin-react-compiler/src/__tests__/Imports-test.tscorepack yarn jest src/__tests__/Imports-test.ts --runInBandgit diff --check