Change domain validation default from monitor to enabled#8141
Open
Change domain validation default from monitor to enabled#8141
Conversation
The burn-in period for domain validation monitoring is complete. Update the default enforcement level of FIDES__SECURITY__DOMAIN_VALIDATION_MODE from "monitor" to "enabled" so disallowed domains are blocked by default.
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8141 +/- ##
=======================================
Coverage 85.23% 85.23%
=======================================
Files 638 638
Lines 42011 42011
Branches 4937 4937
=======================================
+ Hits 35807 35808 +1
Misses 5096 5096
+ Partials 1108 1107 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Vagoasdf
approved these changes
May 8, 2026
Contributor
Vagoasdf
left a comment
There was a problem hiding this comment.
Approved! We should still warn the FDE team when we are merging /releasing this one
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket [ENG-]
Description Of Changes
Changes the default enforcement level of
FIDES__SECURITY__DOMAIN_VALIDATION_MODEfrommonitortoenabled. After the burn-in period, domain validation now actively blocks disallowed domains instead of only logging warnings.To revert to the previous behavior, explicitly set:
Code Changes
domain_validation_modeinSecuritySettingsfrommonitortoenabledvalidate_value_against_allowed_listto matchSteps to Confirm
FIDES__SECURITY__DOMAIN_VALIDATION_MODEDomainValidationErrorFIDES__SECURITY__DOMAIN_VALIDATION_MODE=monitorand confirm requests are only warned, not blockedFIDES__SECURITY__DOMAIN_VALIDATION_MODE=disabledand confirm validation is skipped entirelyPre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works