Skip to content

Sanitize PE redirect locations for ByteString safety#602

Merged
kentcdodds merged 2 commits intomainfrom
typeerror-cannot-convert-s6tr2b
May 1, 2026
Merged

Sanitize PE redirect locations for ByteString safety#602
kentcdodds merged 2 commits intomainfrom
typeerror-cannot-convert-s6tr2b

Conversation

@kentcdodds
Copy link
Copy Markdown
Member

@kentcdodds kentcdodds commented May 1, 2026

Summary

  • decode and re-encode progressive enhancement redirect locations to avoid double-encoding
  • keep redirect sanitization while preserving percent-encoded paths

Testing

  • npm run test
  • Manual: node check for encodeURI(decodeURI(safeRedirect('/foo%20bar')))
Open in Web Open in Cursor 

@cursor
Copy link
Copy Markdown
Contributor

cursor Bot commented May 1, 2026

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented May 1, 2026

View your CI Pipeline Execution ↗ for commit 864a3e6

Command Status Duration Result
nx run-many --target typecheck ✅ Succeeded 12s View ↗
nx run-many --target build ✅ Succeeded 41s View ↗
nx lint ✅ Succeeded 27s View ↗

☁️ Nx Cloud last updated this comment at 2026-05-01 15:45:17 UTC

@kentcdodds kentcdodds marked this pull request as ready for review May 1, 2026 15:08
Copy link
Copy Markdown
Contributor

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 8fb187a. Configure here.

Comment thread packages/workshop-app/app/utils/pe.tsx
@kentcdodds kentcdodds merged commit a3d2740 into main May 1, 2026
10 checks passed
@kentcdodds kentcdodds deleted the typeerror-cannot-convert-s6tr2b branch May 1, 2026 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants