Skip to content

Fix quizMe exercise selection for missing input#600

Merged
kentcdodds merged 2 commits intomainfrom
error-no-exercise-5zxitc
Apr 29, 2026
Merged

Fix quizMe exercise selection for missing input#600
kentcdodds merged 2 commits intomainfrom
error-no-exercise-5zxitc

Conversation

@kentcdodds
Copy link
Copy Markdown
Member

@kentcdodds kentcdodds commented Apr 29, 2026

Summary

  • guard quizMe exercise parsing and pick random exercise when missing
  • add quizMe test coverage for random selection and invalid numbers
  • tighten quizMe test assertions to satisfy typecheck

Testing

  • npm --prefix packages/workshop-mcp run typecheck
  • npm --prefix packages/workshop-mcp run test -- quiz-me.test.ts

Evidence

quiz_me_typecheck_and_tests.mp4

Open in Web Open in Cursor 

Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>
@cursor
Copy link
Copy Markdown
Contributor

cursor Bot commented Apr 29, 2026

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

@kentcdodds kentcdodds marked this pull request as ready for review April 29, 2026 14:22
@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented Apr 29, 2026

View your CI Pipeline Execution ↗ for commit 6d00f2e

Command Status Duration Result
nx run-many --target build ✅ Succeeded 6s View ↗

☁️ Nx Cloud last updated this comment at 2026-04-29 14:23:32 UTC

@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented Apr 29, 2026

View your CI Pipeline Execution ↗ for commit 6d00f2e

Command Status Duration Result
nx run-many --target typecheck ✅ Succeeded 4s View ↗
nx lint ✅ Succeeded 2s View ↗
nx run-many --target build ✅ Succeeded 4s View ↗

☁️ Nx Cloud last updated this comment at 2026-04-29 14:31:42 UTC

Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>
@kentcdodds kentcdodds merged commit e77771d into main Apr 29, 2026
10 checks passed
@kentcdodds kentcdodds deleted the error-no-exercise-5zxitc branch April 29, 2026 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants