feat: upgrade app runtime dependencies#598
Conversation
Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>
…pendencies-78cd Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 63095d1. Configure here.
| "engines": { | ||
| "node": "^8.16.0 || ^10.6.0 || >=11.0.0" | ||
| } | ||
| }, |
There was a problem hiding this comment.
Lockfile missing nested vite@8.0.10 for workshop-app workspace
Medium Severity
The diff removes the packages/workshop-app/node_modules/vite lockfile entry (previously at version 8.0.10) without a corresponding update to the root node_modules/vite (which remains at 7.3.1). The workshop-app's package.json requires exactly "vite": "8.0.10", and the root package.json has an override for "vite": "8.0.10", but the lockfile now has no resolution that satisfies this. Vite 8.x (uses rolldown) and 7.x (uses rollup) are fundamentally different. Running npm ci with this lockfile will either fail due to the inconsistency or resolve to the wrong major version.
Reviewed by Cursor Bugbot for commit 63095d1. Configure here.


Summary
main, including the recently merged dependency PRs for:@mux/mux-player-react^3.11.4 -> ^3.12.0media-chrome^4.17.2 -> ^4.19.0@pierre/diffs^1.0.11 -> ^1.1.19partysocket^1.1.13 -> ^1.1.18satori^0.19.2 -> ^0.26.0mainbaseline changes inpackages/workshop-app/package.json, including the tooling, MCP/auth, app-platform, and Sentry dependency updatespackages/workshop-app/package.jsonpackage-lock.jsonexample/epicshop/package-lock.jsonTest Plan
npm installnpm run validatenpm test(via the repo pre-push hook after pushing)Conflict Review
Simple conflicts fixed
mainmerge overlap in generated lockfiles and package manifestspackage-lock.jsontextual merge conflict resolved by taking latestmainas baseline and regenerating withnpm installComplicated issue reported
packages/workshop-app/package.jsonrequiresvite: "8.0.10"package.jsonoverridesviteto8.0.10npm ci --ignore-scriptson the merged tree still installs rootnode_modules/vite@7.3.1npm ls vite --allreports the install as invalid from the workspace rootNotes
origin/maininstead of rebasing so the branch could be updated without a force-push.