Pass FIN up when EnvoyQuicServerStream is read disabled#44144
Open
wang178c wants to merge 3 commits intoenvoyproxy:mainfrom
Open
Pass FIN up when EnvoyQuicServerStream is read disabled#44144wang178c wants to merge 3 commits intoenvoyproxy:mainfrom
wang178c wants to merge 3 commits intoenvoyproxy:mainfrom
Conversation
…bled. Signed-off-by: Haoyue Wang <haoyuewang@google.com>
Contributor
Author
|
/assign @RyanTheOptimist |
Contributor
Author
|
/retest |
RyanTheOptimist
previously approved these changes
Mar 27, 2026
Contributor
RyanTheOptimist
left a comment
RyanTheOptimist
left a comment
There was a problem hiding this comment.
Should we add a test for this case?
Signed-off-by: Haoyue Wang <haoyuewang@google.com>
Signed-off-by: Haoyue Wang <haoyuewang@google.com>
Contributor
Author
Added one. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: Pass FIN up when EnvoyQuicServerStream is read disabled.
Additional Description: Standalone FIN will be passed up once and only once. Hence this change prevents the FIN getting lost.
Risk Level: low (protected by envoy.reloadable_features.quic_disable_data_read_immediately runtime guard)
Testing: tested in production.