matcher: add a stat action to prepend a metric prefix#44134
Open
kyessenov wants to merge 4 commits intoenvoyproxy:mainfrom
Open
matcher: add a stat action to prepend a metric prefix#44134kyessenov wants to merge 4 commits intoenvoyproxy:mainfrom
kyessenov wants to merge 4 commits intoenvoyproxy:mainfrom
Conversation
This requires refactoring the action factory to return a `StatusOr` in case of an error. Signed-off-by: Kuat Yessenov <kuat@google.com>
kyessenov
requested review from
adisuissa,
agrawroh,
botengyao,
danzh2010,
mattklein123,
tyxia,
wbpcode and
yanavlasov
as code owners
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: This requires refactoring the action factory to return a
StatusOrin case of an error.Additional Description: None
Risk Level: Low
Testing: Done
Docs Changes: None
Release Notes: None
Gemini was used during development.