fix: print correct address in accept() debug log for IPv6#97
Open
kugland wants to merge 2 commits into
Open
Conversation
Verify that --ipv6 mode prints the correct [::1]:PORT in the accept() debug log, not garbage from the uninitialized IPv4 addrin struct.
In IPv6 mode, accept() populates addrin6 but the debug printf always read from the uninitialized addrin (IPv4) struct, printing garbage. Gate on inet6 and use get_address_text() with bracketed IPv6 form.
kugland
force-pushed
the
fix/ipv6-accept-debug-log
branch
from
38ab6b8 to
9902c5c
Compare
Contributor
Author
|
Added a regression test for the bug. Also reversed the commit order — test comes first, so you can check out the first commit to see it fail, then the second to see the fix make it pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In IPv6 mode,
accept()populatesaddrin6but the debugprintfalways read from the uninitializedaddrin(IPv4) struct, printing garbage. Gate oninet6and useget_address_text()with bracketed IPv6 form.Test plan