[cisco_ise] Fix sub pipeline ecs mapping problems and improve mappings for other types#18903
Open
vinit-chauhan wants to merge 3 commits into
Open
Conversation
…come for CISE_Failed_Attempts 5401-5452 and CISE_Passed_Authentications 5201-5241 - Add event.category, event.type, and event.outcome mappings for CISE_Failed_Attempts codes 5401-5452 and CISE_Passed_Authentications codes 5201-5241 that previously had no ECS categorisation. - Set event.outcome=failure unconditionally on all CISE_Failed_Attempts events, regardless of message code. - Fix ECS violations: event.type=denied is not valid under event.category=authentication (codes 5434, 5449, 5451 → changed to event.type=end); event.type=change is not valid under event.category=network (code 5205 → changed to event.type=info). - Add pipeline test fixtures (sample logs + regenerated expected JSON) for every newly mapped message code. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Pinging @elastic/integration-experience (Team:Integration-Experience) |
🚀 Benchmarks reportTo see the full report comment with |
💚 Build Succeeded
History
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
[cisco_ise] Fix missing ECS event categorisation for CISE_Failed_Attempts (5401–5452) and CISE_Passed_Authentications (5201–5241) message codes.
Checklist
changelog.ymlfile.Author's Checklist
event.category/event.typecombinations are valid per the ECS allowed-values matrix for every newly mapped code.event.outcome=failureis now set for every event handled bypipeline_failed_attempts.yml, regardless of message code.elastic-package test pipelinefor thelogdata stream).5200,5231,5233,5239,5400,5405,5411,5418,5435,5440).How to test this PR locally
To spot-check specific codes manually, look at:
data_stream/log/_dev/test/pipeline/test-pipeline-failed-attempts.log(and its-expected.json) — covers codes5400,5401,5402,5403,5405,5406,5407,5408,5409,5410,5411,5412,5413,5414,5415,5416,5417,5418,5419,5420,5421,5422,5423,5434,5435,5436,5437,5438,5439,5440,5441,5442,5443,5448,5449,5450,5451,5452.data_stream/log/_dev/test/pipeline/test-pipeline-passed-authentications.log(and its-expected.json) — covers codes5200,5201,5202,5203,5204,5205,5206,5231,5232,5233,5234,5235,5236,5237,5238,5239,5240,5241.For each event, verify
event.category,event.type, andevent.outcomeare set as described in the proposed commit message.Related issues
Screenshots