[fix] Fix failing netbox system tests#18883
Closed
Niceplace wants to merge 2 commits into
Closed
Conversation
…both data streams
Contributor
Author
|
Note: this PR will most likely have failing tests related to the |
🚀 Benchmarks reportTo see the full report comment with |
💚 Build Succeeded
|
Contributor
Author
|
Duplicate of #18679, will close the current PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Fixes broken system tests for netbox integration for the
devicesandipsdata streams by adding the requireddisable_keep_aliveproperty into each test's config.The
disable_keep_alivekey is required: https://github.com/elastic/integrations/blob/main/packages/netbox/manifest.yml#L84-L86 and ommiting it causes system tests to fail with errorsHow to test this PR locally
cd packages/netboxelastic-package up -delastic-package test systemdisable_keep_aliveproperty frompackages/netbox/data_stream/devices/_dev/test/system/test-default-config.ymlandpackages/netbox/data_stream/ips/_dev/test/system/test-default-config.ymlelastic-package test systemRelated PRs experiencing the same falure