Skip to content

[fix] Fix failing netbox system tests#18883

Closed
Niceplace wants to merge 2 commits into
mainfrom
fix/failing-netbox-tests
Closed

[fix] Fix failing netbox system tests#18883
Niceplace wants to merge 2 commits into
mainfrom
fix/failing-netbox-tests

Conversation

@Niceplace
Copy link
Copy Markdown
Contributor

Proposed commit message

Fixes broken system tests for netbox integration for the devices and ips data streams by adding the required disable_keep_alive property into each test's config.

The disable_keep_alive key is required: https://github.com/elastic/integrations/blob/main/packages/netbox/manifest.yml#L84-L86 and ommiting it causes system tests to fail with errors

ERROR: could not add data stream config to policy: could not create package policy (req {"name":"netbox-devices-47415","description":"","namespace":"47415","policy_id":"62ee41fa-2eb1-417e-b19a-373e670b72a4","package":{"name":"netbox","version":"0.1.0"},"inputs":{"netbox-httpjson":{"enabled":true,"vars":{"enable_request_tracer":true,"token":"--token--","url":"http://svc-netbox_mock:8080"},"streams":{"netbox.devices":{"enabled":true,"vars":{"limit":2,"preserve_original_event":true}},"netbox.ips":{"enabled":false}}}},"force":false}); API status code = 400; response body = {"statusCode":400,"error":"Bad Request","message":"Package policy is invalid: inputs.httpjson.vars.disable_keep_alive: [\"Disable HTTP Keep-Alives is required\"]"}

How to test this PR locally

  1. From the repo root cd packages/netbox
  2. Start the stack elastic-package up -d
  3. Run system tests elastic-package test system
  4. Notice they all pass
  5. Remove disable_keep_alive property from packages/netbox/data_stream/devices/_dev/test/system/test-default-config.yml and packages/netbox/data_stream/ips/_dev/test/system/test-default-config.yml
  6. Run the system tests again elastic-package test system
  7. Notice the tests fail with the error mentioned above

Related PRs experiencing the same falure

@Niceplace Niceplace requested a review from a team as a code owner May 7, 2026 20:49
@Niceplace
Copy link
Copy Markdown
Contributor Author

Niceplace commented May 7, 2026

Note: this PR will most likely have failing tests related to the aws.config integration which would be fixed by #18881, I'm keeping the two fixes separate for scoping reason but we could stack the PRs together if we want to.

@elastic-vault-github-plugin-prod
Copy link
Copy Markdown

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link
Copy Markdown

💚 Build Succeeded

@Niceplace
Copy link
Copy Markdown
Contributor Author

Duplicate of #18679, will close the current PR.

@Niceplace Niceplace closed this May 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants