Skip to content

[cloudflare_logpush] fix several ingest pipeline and field definition bugs across multiple data streams#18673

Merged
brijesh-elastic merged 7 commits into
elastic:mainfrom
brijesh-elastic:cloudflare_logpush-1.44.1
May 8, 2026
Merged

[cloudflare_logpush] fix several ingest pipeline and field definition bugs across multiple data streams#18673
brijesh-elastic merged 7 commits into
elastic:mainfrom
brijesh-elastic:cloudflare_logpush-1.44.1

Conversation

@brijesh-elastic
Copy link
Copy Markdown
Collaborator

@brijesh-elastic brijesh-elastic commented Apr 28, 2026

Proposed commit message

cloudflare_logpush: fix several ingest pipeline and field definition bugs across multiple data streams

Bugfixes:
- Fix incorrect field-path references and PascalCase mismatches with Cloudflare JSON keys.
- Fix `dns` and `gateway_dns` to populate `related.hosts` and `related.ip` from the correct
  package fields.
- Fix `gateway_network` GeoIP enrichment to tolerate missing source and destination IPs.
- Fix `network_analytics` TCP SACK blocks split ordering and empty-string handling.
- Fix swapped field descriptions in `firewall_event` and `http_request`.
- Remove orphaned `page_shield_events.page` field that was never populated.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

How to test this PR locally

  • Clone integrations repo.
  • Install elastic package locally.
  • Start elastic stack using elastic-package.
  • Move to integrations/packages/cloudflare_logpush directory.
  • Run the following command to run tests.

elastic-package test -v

@brijesh-elastic brijesh-elastic self-assigned this Apr 28, 2026
@brijesh-elastic brijesh-elastic requested a review from a team as a code owner April 28, 2026 11:44
@brijesh-elastic brijesh-elastic added Integration:cloudflare_logpush Cloudflare Logpush bugfix Pull request that fixes a bug issue Category: Integration quality Category: Quality used for SI planning Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] Team:SDE-Crest Crest developers on the Security Integrations team [elastic/sit-crest-contractors] labels Apr 28, 2026
@infra-vault-gh-plugin-prod
Copy link
Copy Markdown

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 29, 2026

Vale Linting Results

Summary: 16 warnings, 8 suggestions found

⚠️ Warnings (16)
File Line Rule Message
packages/cloudflare_logpush/docs/README.md 108 Elastic.DontUse Don't use 'please'.
packages/cloudflare_logpush/docs/README.md 112 Elastic.Latinisms Latin terms and abbreviations are a common source of confusion. Use 'for example' instead of 'e.g'.
packages/cloudflare_logpush/docs/README.md 119 Elastic.Latinisms Latin terms and abbreviations are a common source of confusion. Use 'using' instead of 'via'.
packages/cloudflare_logpush/docs/README.md 131 Elastic.DontUse Don't use 'just'.
packages/cloudflare_logpush/docs/README.md 139 Elastic.Latinisms Latin terms and abbreviations are a common source of confusion. Use 'using' instead of 'via'.
packages/cloudflare_logpush/docs/README.md 150 Elastic.Latinisms Latin terms and abbreviations are a common source of confusion. Use 'using' instead of 'via'.
packages/cloudflare_logpush/docs/README.md 151 Elastic.DontUse Don't use 'Please'.
packages/cloudflare_logpush/docs/README.md 152 Elastic.DontUse Don't use 'please'.
packages/cloudflare_logpush/docs/README.md 192 Elastic.Latinisms Latin terms and abbreviations are a common source of confusion. Use 'using' instead of 'via'.
packages/cloudflare_logpush/docs/README.md 965 Elastic.Latinisms Latin terms and abbreviations are a common source of confusion. Use 'that is' instead of 'i.e'.
packages/cloudflare_logpush/docs/README.md 1259 Elastic.Latinisms Latin terms and abbreviations are a common source of confusion. Use 'using' instead of 'via'.
packages/cloudflare_logpush/docs/README.md 2306 Elastic.Latinisms Latin terms and abbreviations are a common source of confusion. Use 'for example' instead of 'eg'.
packages/cloudflare_logpush/docs/README.md 2333 Elastic.Latinisms Latin terms and abbreviations are a common source of confusion. Use 'using' instead of 'via'.
packages/cloudflare_logpush/docs/README.md 2563 Elastic.Latinisms Latin terms and abbreviations are a common source of confusion. Use 'using' instead of 'via'.
packages/cloudflare_logpush/docs/README.md 3628 Elastic.BritishSpellings Use American English spelling 'acknowledgment' instead of British English 'Acknowledgement'.
packages/cloudflare_logpush/docs/README.md 3906 Elastic.Latinisms Latin terms and abbreviations are a common source of confusion. Use 'using' instead of 'via'.
💡 Suggestions (8)
File Line Rule Message
packages/cloudflare_logpush/docs/README.md 5 Elastic.Semicolons Use semicolons judiciously.
packages/cloudflare_logpush/docs/README.md 5 Elastic.Semicolons Use semicolons judiciously.
packages/cloudflare_logpush/docs/README.md 5 Elastic.Semicolons Use semicolons judiciously.
packages/cloudflare_logpush/docs/README.md 182 Elastic.WordChoice Consider using 'refer to if it's a document, view if it's a UI element' instead of 'See', unless the term is in the UI.
packages/cloudflare_logpush/docs/README.md 673 Elastic.WordChoice Consider using 'can, might' instead of 'may', unless the term is in the UI.
packages/cloudflare_logpush/docs/README.md 1695 Elastic.WordChoice Consider using 'top-level' instead of 'first-class', unless the term is in the UI.
packages/cloudflare_logpush/docs/README.md 2317 Elastic.WordChoice Consider using 'can, might' instead of 'may', unless the term is in the UI.
packages/cloudflare_logpush/docs/README.md 2995 Elastic.Wordiness Consider using 'whether' instead of 'Whether or not'.

The Vale linter checks documentation changes against the Elastic Docs style guide.

To use Vale locally or report issues, refer to Elastic style guide for Vale.

@andrewkroh andrewkroh added the documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. label Apr 29, 2026
Comment thread packages/cloudflare_logpush/changelog.yml Outdated
Comment thread packages/cloudflare_logpush/changelog.yml
Comment thread packages/cloudflare_logpush/changelog.yml Outdated
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 6, 2026

TL;DR

Build 42405 failed before repository code execution: the Buildkite agent environment hook could not retrieve Vault secret github/token/elastic-integrations-pipeline and aborted pipeline upload. Immediate action is to restore/validate that Vault path (or role mapping) and then retry the build.

Remediation

  • Ensure Vault has a value at github/token/elastic-integrations-pipeline and that role elastic-integrations-pipeline can read it from this pipeline context.
  • Re-run the build after secret/path access is fixed; no code change in this PR is indicated by this failure.
Investigation details

Root Cause

The failed job is :pipeline::arrow_up: Upload Pipeline: .buildkite/pipeline.yml, but the failure occurs in the agent environment hook prior to command execution. The hook repeatedly attempts to fetch the GitHub token from Vault and exits non-zero after retries.

This is an infrastructure/configuration failure (secret provisioning/access), not a test/code/runtime failure in PR changes.

Evidence

Attempting to retrieve GitHub token from Vault at path: github/token/elastic-integrations-pipeline
No value found at github/token/elastic-integrations-pipeline
Retry 5/5 exited 2, no more retries left.
Error setting up job executor: running "agent environment" shell hook: The agent environment hook exited with status 1

Verification

  • Not run: build does not reach repository code/test steps; it fails during CI environment bootstrap.

Follow-up

  • If the Vault path and role permissions are correct but intermittent, classify as transient infra and retry once after confirming secret backend health.

Note

🔒 Integrity filter blocked 2 items

The following items were blocked because they don't meet the GitHub integrity level.

To allow these resources, lower min-integrity in your GitHub frontmatter:

tools:
  github:
    min-integrity: approved  # merged | approved | unapproved | none

What is this? | From workflow: PR Buildkite Detective

Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.

@brijesh-elastic brijesh-elastic force-pushed the cloudflare_logpush-1.44.1 branch from f481364 to 70d3f38 Compare May 6, 2026 11:51
@brijesh-elastic
Copy link
Copy Markdown
Collaborator Author

I'm separating the breaking changes into a different PR, which will be merged after all bug fixes and enhancements. This benefits users who want the latest fixes & improvements without being forced to adopt breaking changes yet.

cc: @kcreddy

@brijesh-elastic brijesh-elastic requested a review from kcreddy May 6, 2026 12:00
@elastic-vault-github-plugin-prod
Copy link
Copy Markdown

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

Copy link
Copy Markdown
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one comment pending - #18673 (comment)

Comment thread packages/cloudflare_logpush/data_stream/gateway_dns/fields/fields.yml Outdated
@brijesh-elastic brijesh-elastic requested review from efd6 and kcreddy May 7, 2026 10:48
Copy link
Copy Markdown
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for my comments 👍🏼

@elasticmachine
Copy link
Copy Markdown

💚 Build Succeeded

History

cc @brijesh-elastic

Copy link
Copy Markdown
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@brijesh-elastic brijesh-elastic merged commit 2a2f24b into elastic:main May 8, 2026
14 checks passed
@elastic-vault-github-plugin-prod
Copy link
Copy Markdown

Package cloudflare_logpush - 1.44.1 containing this change is available at https://epr.elastic.co/package/cloudflare_logpush/1.44.1/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug issue Category: Integration quality Category: Quality used for SI planning documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. Integration:cloudflare_logpush Cloudflare Logpush Team:SDE-Crest Crest developers on the Security Integrations team [elastic/sit-crest-contractors] Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants