feat(branch-prefix): add repo-level override#509
Open
davinkevin wants to merge 1 commit into
Open
Conversation
Implement the repo-level `branchPrefix` config option that PR ejoffe#494 announced in its commit message ("It can be set at user level or at repo level, with repo taking precedence") but didn't ship in the code. Introduce `Config.BranchPrefix()` helper that returns the effective prefix with the precedence rule applied and trims any trailing slash. All call sites in git/helpers.go, github/githubclient/client.go and spr/spr.go are updated to use this helper instead of reading User.BranchPrefix directly. Related to ejoffe#494
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement the repo-level
branchPrefixconfig option that PR #494announced in its commit message ("It can be set at user level or at
repo level, with repo taking precedence") but didn't ship in the code.
Introduce
Config.BranchPrefix()helper that returns the effectiveprefix with the precedence rule applied and trims any trailing slash.
All call sites in git/helpers.go, github/githubclient/client.go and
spr/spr.go are updated to use this helper instead of reading
User.BranchPrefix directly.
Related to #494