Skip to content

Refactor DiffPool out of server.py (Fixes #243)#244

Open
Tanishk008 wants to merge 1 commit intoedgi-govdata-archiving:mainfrom
Tanishk008:main
Open

Refactor DiffPool out of server.py (Fixes #243)#244
Tanishk008 wants to merge 1 commit intoedgi-govdata-archiving:mainfrom
Tanishk008:main

Conversation

@Tanishk008
Copy link
Copy Markdown

This PR resolves Issue #243.

Modifications:

  • Created server/diff_pool.py to cleanly encapsulate the worker process pool management, MAX_DIFFS_PER_WORKER resets, and concurrent execution retries.
  • Removed the heavily coupled diff execution and shutdown logic from server.py and DiffHandler.
  • The DiffHandler HTTP routes now simply delegate execution to the DiffPool object initialized inside make_app().

Copy link
Copy Markdown
Member

@Mr0grog Mr0grog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Tanishk008, I am at a conference this week and won’t have time for a closer look for a few days, but can you please make sure the tests and CI tasks pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants